[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Z_peBtLuLhEDHqga@pollux>
Date: Sat, 12 Apr 2025 14:35:18 +0200
From: Danilo Krummrich <dakr@...nel.org>
To: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Cc: Christian Schrefl <chrisi.schrefl@...il.com>,
Luis Chamberlain <mcgrof@...nel.org>,
Russ Weight <russ.weight@...ux.dev>,
Miguel Ojeda <ojeda@...nel.org>,
Alex Gaynor <alex.gaynor@...il.com>,
Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
Björn Roy Baron <bjorn3_gh@...tonmail.com>,
Benno Lossin <benno.lossin@...ton.me>,
Andreas Hindborg <a.hindborg@...nel.org>,
Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
linux-kernel@...r.kernel.org, rust-for-linux@...r.kernel.org
Subject: Re: [PATCH v2] rust: Use `ffi::c_char` type in firmware abstraction
`FwFunc`
On Sat, Apr 12, 2025 at 01:59:48PM +0200, Miguel Ojeda wrote:
> On Sat, Apr 12, 2025 at 12:30 PM Christian Schrefl
> <chrisi.schrefl@...il.com> wrote:
> >
> > "propper" type for this, so use a `*const kernel::ffi::c_char` pointer
> > instad.
>
> A couple typos -- I usually suggest using e.g. `scripts/checkpatch.pl
> --codespell`.
>
> > This should probably be backported to stable, for people/distros
> > using Arm 32 patches on stable.
>
> Up to the stable team -- I will add Cc: stable when I pick it up since
> it shouldn't hurt, but it does not change anything there for the
> supported arches, so they may or may not want to pick it.
Typically, firmware patches go through driver-core, but if you like I'm fine
with you taking it through the Rust tree.
Acked-by: Danilo Krummrich <dakr@...nel.org>
I don't think backporting it hurts, but it's also not really necessary. Like
Miguel says, up to the stable team.
Just note that before v6.13, core::ffi is required, since kernel::ffi does not
exist. The firmware abstractions were introduced with v6.11.
- Danilo
Powered by blists - more mailing lists