linux-kernel - Re: [PATCH v2] rust: Use `ffi::c_char` type in firmware abstraction `FwFunc`

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a7195308-e019-4587-8bc3-ad34de192708@gmail.com>
Date: Sat, 12 Apr 2025 15:55:42 +0200
From: Christian Schrefl <chrisi.schrefl@...il.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Cc: Luis Chamberlain <mcgrof@...nel.org>, Russ Weight
 <russ.weight@...ux.dev>, Danilo Krummrich <dakr@...nel.org>,
 Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>,
 Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>,
 Benno Lossin <benno.lossin@...ton.me>,
 Andreas Hindborg <a.hindborg@...nel.org>, Alice Ryhl <aliceryhl@...gle.com>,
 Trevor Gross <tmgross@...ch.edu>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 linux-kernel@...r.kernel.org, rust-for-linux@...r.kernel.org
Subject: Re: [PATCH v2] rust: Use `ffi::c_char` type in firmware abstraction
 `FwFunc`

On 12.04.25 1:59 PM, Miguel Ojeda wrote:
> On Sat, Apr 12, 2025 at 12:30 PM Christian Schrefl
> <chrisi.schrefl@...il.com> wrote:
>>
>> "propper" type for this, so use a `*const kernel::ffi::c_char` pointer
>> instad.
> 
> A couple typos -- I usually suggest using e.g. `scripts/checkpatch.pl
> --codespell`.
Do you want me to send a v3 with that fixed or are you going to do that
when applying.

(I've now configured my `b4 check` to add `--codespell`)

> 
>> This should probably be backported to stable, for people/distros
>> using Arm 32 patches on stable.
> 
> Up to the stable team -- I will add Cc: stable when I pick it up since
> it shouldn't hurt, but it does not change anything there for the
> supported arches, so they may or may not want to pick it.
> 
> Thanks!
> 
> Cheers,
> Miguel