linux-kernel - Re: [PATCH] iio: normalize array sentinel style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VcdpPC2faWNMupXL-RaEM3QsSYEyfSC+A7KEsmD24U=+Q@mail.gmail.com>
Date: Sat, 12 Apr 2025 15:55:35 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: David Lechner <dlechner@...libre.com>
Cc: Jonathan Cameron <jic23@...nel.org>, Nuno Sá <nuno.sa@...log.com>, 
	Andy Shevchenko <andy@...nel.org>, linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-staging@...ts.linux.dev
Subject: Re: [PATCH] iio: normalize array sentinel style

On Fri, Apr 11, 2025 at 11:50 PM David Lechner <dlechner@...libre.com> wrote:
>
> Use `\t(\{ ?\},|\{\}|\{\s*/\*.*\*/\s*\},?)$` regex to find and replace
> the array sentinel in all IIO drivers to the same style.
>
> For some time, we've been trying to consistently use `{ }` (no trailing
> comma, no comment, one space between braces) for array sentinels in the
> IIO subsystem. Still nearly 50% of existing code uses a different style.
> To save reviewers from having to request this trivial change as
> frequently, let's normalize the style in all existing IIO drivers.
> At least when code is copy/pasted to new drivers, the style will be
> consistent.

With or without iiner space, but same style. What is important is that
you removed the trailing commas.
Reviewed-by: Andy Shevchenko <andy@...nel.org>

-- 
With Best Regards,
Andy Shevchenko