linux-kernel - Re: [PATCH] iio: normalize array sentinel style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250413103950.23c20bd3@jic23-huawei>
Date: Sun, 13 Apr 2025 10:39:50 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: David Lechner <dlechner@...libre.com>, Nuno Sá
 <nuno.sa@...log.com>, Andy Shevchenko <andy@...nel.org>,
 linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-staging@...ts.linux.dev
Subject: Re: [PATCH] iio: normalize array sentinel style

On Sat, 12 Apr 2025 15:55:35 +0300
Andy Shevchenko <andy.shevchenko@...il.com> wrote:

> On Fri, Apr 11, 2025 at 11:50 PM David Lechner <dlechner@...libre.com> wrote:
> >
> > Use `\t(\{ ?\},|\{\}|\{\s*/\*.*\*/\s*\},?)$` regex to find and replace
> > the array sentinel in all IIO drivers to the same style.
> >
> > For some time, we've been trying to consistently use `{ }` (no trailing
> > comma, no comment, one space between braces) for array sentinels in the
> > IIO subsystem. Still nearly 50% of existing code uses a different style.
> > To save reviewers from having to request this trivial change as
> > frequently, let's normalize the style in all existing IIO drivers.
> > At least when code is copy/pasted to new drivers, the style will be
> > consistent.  
> 
> With or without iiner space, but same style. What is important is that
> you removed the trailing commas.
> Reviewed-by: Andy Shevchenko <andy@...nel.org>
> 
Agreed. The space thing was a random choice, but consistency is good
and comma part matters more.  

Applied.  One case had already gone away in my tree and there was a little
fuzz but should all be fine.

Thanks,

Jonathan