linux-kernel - Re: [PATCH] staging: greybus: Reformat code in gb_operation_sync

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <BF2CF4C6-5381-4266-9E49-9C81E9604007@linux.dev>
Date: Mon, 14 Apr 2025 17:00:41 +0200
From: Thorsten Blum <thorsten.blum@...ux.dev>
To: Johan Hovold <johan@...nel.org>
Cc: Alex Elder <elder@...nel.org>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 greybus-dev@...ts.linaro.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: greybus: Reformat code in
 gb_operation_sync_timeout()

On 14. Apr 2025, at 09:05, Johan Hovold wrote:
> This just makes the code *less* readable.

I guess you prefer the code with curly braces?

What about the Linux kernel coding style [1]? Specifically "Do not
unnecessarily use braces where a single statement will do."

My patch just removes any unnecessary curly braces, resulting in less
lines of code and no line break in the memcpy() arguments.

Thanks,
Thorsten

[1] https://docs.kernel.org/process/coding-style.html#placing-braces-and-spaces