linux-kernel - Re: [PATCH] staging: greybus: Reformat code in gb_operation_sync

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z_3-XS2DHEbqkSdx@hovoldconsulting.com>
Date: Tue, 15 Apr 2025 08:36:13 +0200
From: Johan Hovold <johan@...nel.org>
To: Thorsten Blum <thorsten.blum@...ux.dev>
Cc: Alex Elder <elder@...nel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	greybus-dev@...ts.linaro.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: greybus: Reformat code in
 gb_operation_sync_timeout()

On Mon, Apr 14, 2025 at 05:00:41PM +0200, Thorsten Blum wrote:
> On 14. Apr 2025, at 09:05, Johan Hovold wrote:
> > This just makes the code *less* readable.
> 
> I guess you prefer the code with curly braces?

Around multiline statements yes, but the proposed if-else here also
obscures the logic for no good reason.

> What about the Linux kernel coding style [1]? Specifically "Do not
> unnecessarily use braces where a single statement will do."
> 
> My patch just removes any unnecessary curly braces, resulting in less
> lines of code and no line break in the memcpy() arguments.

I really don't care, the code is more readable as it stands which is
what matters.

If you want to practise sending patches you can send all the "cleanups"
you want for code in drivers/staging where churn like this may be
accepted (and where the core greybus code no longer lives, contrary to
what your Subject suggests).

Johan