linux-kernel - Re: [PATCH v3 2/2] writeback: Fix false warning in inode_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHc6FU4CAzrNO24izcwYXFt-K0WFUdM6y0bAzmW6nb1CS0sexg@mail.gmail.com>
Date: Tue, 15 Apr 2025 01:22:29 +0200
From: Andreas Gruenbacher <agruenba@...hat.com>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: cgroups@...r.kernel.org, Jan Kara <jack@...e.cz>, 
	Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>, Rafael Aquini <aquini@...hat.com>, 
	gfs2@...ts.linux.dev, linux-mm@...ck.org, linux-fsdevel@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/2] writeback: Fix false warning in inode_to_wb()

On Mon, Apr 14, 2025 at 11:51 PM Andrew Morton
<akpm@...ux-foundation.org> wrote:
> On Sat, 12 Apr 2025 18:39:12 +0200 Andreas Gruenbacher <agruenba@...hat.com> wrote:
>
> > inode_to_wb() is used also for filesystems that don't support cgroup
> > writeback. For these filesystems inode->i_wb is stable during the
> > lifetime of the inode (it points to bdi->wb) and there's no need to hold
> > locks protecting the inode->i_wb dereference. Improve the warning in
> > inode_to_wb() to not trigger for these filesystems.
> >
> > Signed-off-by: Jan Kara <jack@...e.cz>
> > Reviewed-by: Andreas Gruenbacher <agruenba@...hat.com>
>
> Yoo were on the patch delivery path so there should be a
> signed-off-by:Andreas somewhere.  I made that change to the mm.git copy
> of this patch.

I guess that's fine as long as Jan is credited as the author.

Thanks,
Andreas