linux-kernel - Re: [PATCH v2 12/12] arm64: dts: renesas: Add initial device tree for RZ/V2N EVK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+V-a8vzPuxAqJ8waJWw0TNRqV5FMeuojZ7bxfPJzLMPNdy79g@mail.gmail.com>
Date: Mon, 14 Apr 2025 09:39:58 +0100
From: "Lad, Prabhakar" <prabhakar.csengg@...il.com>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: Michael Turquette <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Linus Walleij <linus.walleij@...aro.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
	Jiri Slaby <jirislaby@...nel.org>, Magnus Damm <magnus.damm@...il.com>, 
	linux-renesas-soc@...r.kernel.org, linux-clk@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-gpio@...r.kernel.org, linux-serial@...r.kernel.org, 
	Biju Das <biju.das.jz@...renesas.com>, 
	Fabrizio Castro <fabrizio.castro.jz@...esas.com>, 
	Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
Subject: Re: [PATCH v2 12/12] arm64: dts: renesas: Add initial device tree for
 RZ/V2N EVK

Hi Geert,

Thank you for the review.

On Thu, Apr 10, 2025 at 1:07 PM Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
>
> Hi Prabhakar,
>
> On Mon, 7 Apr 2025 at 21:16, Prabhakar <prabhakar.csengg@...il.com> wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> >
> > Add the initial device tree for the Renesas RZ/V2N EVK board, based on
> > the R9A09G056N48 SoC. Enable basic board functionality, including:
> >
> > - Memory mapping (reserve the first 128MB for the secure area)
> > - Clock inputs (QEXTAL, RTXIN, AUDIO_EXTAL)
> > - PINCTRL configurations for peripherals
> > - Serial console (SCIF)
> > - SDHI1 with power control and UHS modes
> >
> > Update the Makefile to include the new DTB.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> > ---
> > v1->v2
> > - Followed DTS coding style guidelines
>
> Thanks for the update!
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>
> i.e. will queue in renesas-devel for v6.16.
>
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/renesas/r9a09g056n48-rzv2n-evk.dts
>
> > +&pinctrl {
>
> > +       sdhi1_pins: sd1 {
> > +               sd1-dat-cmd {
> > +                       pins = "SD1DAT0", "SD1DAT1", "SD1DAT2", "SD1DAT3", "SD1CMD";
> > +                       input-enable;
> > +                       renesas,output-impedance = <3>;
> > +                       slew-rate = <0>;
> > +               };
> > +
> > +               sd1-clk {
> > +                       pins = "SD1CLK";
> > +                       renesas,output-impedance = <3>;
> > +                       slew-rate = <0>;
> > +               };
> > +
> > +               sd1-cd {
> > +                       pinmux = <RZV2N_PORT_PINMUX(9, 4, 14)>; /* SD1_CD */
> > +               };
>
> I will sort these subnodes while applying.
>
Thanks for taking care.

Cheers,
Prabhakar