linux-kernel - Re: [PATCH v6 07/12] gpio: regmap: Allow to allocate regmap-irq device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z_zjki8ShybzpWDk@smile.fi.intel.com>
Date: Mon, 14 Apr 2025 13:29:38 +0300
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Mathieu Dubois-Briand <mathieu.dubois-briand@...tlin.com>
Cc: Lee Jones <lee@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Kamel Bouhara <kamel.bouhara@...tlin.com>,
	Linus Walleij <linus.walleij@...aro.org>,
	Bartosz Golaszewski <brgl@...ev.pl>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Uwe Kleine-König <ukleinek@...nel.org>,
	Michael Walle <mwalle@...nel.org>, Mark Brown <broonie@...nel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	Danilo Krummrich <dakr@...nel.org>, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
	linux-input@...r.kernel.org, linux-pwm@...r.kernel.org,
	Grégory Clement <gregory.clement@...tlin.com>,
	Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH v6 07/12] gpio: regmap: Allow to allocate regmap-irq
 device

On Thu, Apr 10, 2025 at 11:03:46AM +0200, Mathieu Dubois-Briand wrote:
> On Wed Apr 9, 2025 at 6:39 PM CEST, Andy Shevchenko wrote:
> > On Wed, Apr 09, 2025 at 04:55:54PM +0200, Mathieu Dubois-Briand wrote:

...

> >> +#ifdef CONFIG_REGMAP_IRQ
> >> +	if (config->regmap_irq_chip) {
> >> +		struct regmap_irq_chip_data *irq_chip_data;
> >> +
> >> +		ret = devm_regmap_add_irq_chip_fwnode(config->parent, dev_fwnode(config->parent),
> >> +						      config->regmap, config->regmap_irq_irqno,
> >> +						      config->regmap_irq_flags, 0,
> >> +						      config->regmap_irq_chip, &irq_chip_data);
> >> +		if (ret)
> >> +			goto err_free_gpio;
> >> +
> >> +		irq_domain = regmap_irq_get_domain(irq_chip_data);
> >> +	} else
> >> +#endif
> >> +	irq_domain = config->irq_domain;
> >
> >> +
> >
> > This is blank line is not needed, but I not mind either way.
> 
> I can remove it, but as the line above is potentially part of the
> "else", I have a small preference for keeping it.

Yes, but it's still coupled with the flow. But okay to leave as is.

> >> +	if (irq_domain) {
> >> +		ret = gpiochip_irqchip_add_domain(chip, irq_domain);
> >>  		if (ret)
> >>  			goto err_remove_gpiochip;
> >>  	}

-- 
With Best Regards,
Andy Shevchenko