linux-kernel - Re: [PATCH v6 01/12] dt-bindings: mfd: gpio: Add MAX7360

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <D976AGJAXE3S.1AUQ47D8Q28SG@bootlin.com>
Date: Tue, 15 Apr 2025 13:24:01 +0200
From: "Mathieu Dubois-Briand" <mathieu.dubois-briand@...tlin.com>
To: "Rob Herring (Arm)" <robh@...nel.org>
Cc: "Linus Walleij" <linus.walleij@...aro.org>, "Lee Jones"
 <lee@...nel.org>, "Rafael J. Wysocki" <rafael@...nel.org>,
 <andriy.shevchenko@...el.com>, Uwe Kleine-König
 <ukleinek@...nel.org>, "Conor Dooley" <conor+dt@...nel.org>, "Thomas
 Petazzoni" <thomas.petazzoni@...tlin.com>, "Kamel Bouhara"
 <kamel.bouhara@...tlin.com>, <linux-kernel@...r.kernel.org>, "Michael
 Walle" <mwalle@...nel.org>, <linux-pwm@...r.kernel.org>, "Bartosz
 Golaszewski" <brgl@...ev.pl>, "Danilo Krummrich" <dakr@...nel.org>, "Mark
 Brown" <broonie@...nel.org>, Grégory Clement
 <gregory.clement@...tlin.com>, "Dmitry Torokhov"
 <dmitry.torokhov@...il.com>, "Greg Kroah-Hartman"
 <gregkh@...uxfoundation.org>, <linux-gpio@...r.kernel.org>,
 <linux-input@...r.kernel.org>, "Krzysztof Kozlowski" <krzk+dt@...nel.org>,
 <devicetree@...r.kernel.org>
Subject: Re: [PATCH v6 01/12] dt-bindings: mfd: gpio: Add MAX7360

On Fri Apr 11, 2025 at 6:05 PM CEST, Rob Herring (Arm) wrote:
>
> On Wed, 09 Apr 2025 16:55:48 +0200, Mathieu Dubois-Briand wrote:
>> Add device tree bindings for Maxim Integrated MAX7360 device with
>> support for keypad, rotary, gpios and pwm functionalities.
>> 
>> Signed-off-by: Mathieu Dubois-Briand <mathieu.dubois-briand@...tlin.com>
>> ---
>>  .../bindings/gpio/maxim,max7360-gpio.yaml          |  83 ++++++++++
>>  .../devicetree/bindings/mfd/maxim,max7360.yaml     | 171 +++++++++++++++++++++
>>  2 files changed, 254 insertions(+)
>> 
>
> With the typos fixed,
>
> Reviewed-by: Rob Herring (Arm) <robh@...nel.org>

Thanks for the tag!

As a quick note, I believe the bindings will be slightly modified in
next version, to address requests on the rotary encoder driver:

--- c/Documentation/devicetree/bindings/mfd/maxim,max7360.yaml
+++ w/Documentation/devicetree/bindings/mfd/maxim,max7360.yaml
@@ -54,6 +54,17 @@ properties:
   linux,axis:
     $ref: /schemas/input/rotary-encoder.yaml#/properties/linux,axis

+  rotary-encoder,relative-axis:
+    $ref: /schemas/input/rotary-encoder.yaml#/properties/rotary-encoder,relative-axis
+    description:
+      Register a relative axis rather than an absolute one.
+
+  rotary-encoder,steps:
+    $ref: /schemas/input/rotary-encoder.yaml#/properties/rotary-encoder,steps
+
+  rotary-encoder,rollover:
+    $ref: /schemas/input/rotary-encoder.yaml#/properties/rotary-encoder,rollover
+
   "#pwm-cells":
     const: 3

Best regards,
Mathieu

-- 
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com