linux-kernel - Re: [PATCH net-next v2] net: ncsi: Fix GCPS 64-bit member variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z/5FzySnQ2y3stpj@home.paul.comp>
Date: Tue, 15 Apr 2025 14:41:03 +0300
From: Paul Fertser <fercerpav@...il.com>
To: kalavakunta.hari.prasad@...il.com
Cc: sam@...dozajonas.com, davem@...emloft.net, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com, horms@...nel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        npeacock@...a.com, akozlov@...a.com, hkalavakunta@...a.com
Subject: Re: [PATCH net-next v2] net: ncsi: Fix GCPS 64-bit member variables

Hello,

On Wed, Apr 09, 2025 at 06:23:08PM -0700, kalavakunta.hari.prasad@...il.com wrote:
> From: Hari Kalavakunta <kalavakunta.hari.prasad@...il.com>
> 
> Correct Get Controller Packet Statistics (GCPS) 64-bit wide member
> variables, as per DSP0222 v1.0.0 and forward specs. The Driver currently
> collects these stats, but they are yet to be exposed to the user.
> Therefore, no user impact.
> 
> Statistics fixes:
> Total Bytes Received (byte range 28..35)
> Total Bytes Transmitted (byte range 36..43)
> Total Unicast Packets Received (byte range 44..51)
> Total Multicast Packets Received (byte range 52..59)
> Total Broadcast Packets Received (byte range 60..67)
> Total Unicast Packets Transmitted (byte range 68..75)
> Total Multicast Packets Transmitted (byte range 76..83)
> Total Broadcast Packets Transmitted (byte range 84..91)
> Valid Bytes Received (byte range 204..11)
> 
> v2:
> - __be64 for all 64 bit GCPS counters
> 
> Signed-off-by: Hari Kalavakunta <kalavakunta.hari.prasad@...il.com>

This version looks correct to me (other than the changelog being
before ---) so

Reviewed-by: Paul Fertser <fercerpav@...il.com>