linux-kernel - [PATCH v2] dmaengine: ptdma: Remove unused pointer dma_cmd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250415121312.870124-1-ezulian@redhat.com>
Date: Tue, 15 Apr 2025 14:13:12 +0200
From: Eder Zulian <ezulian@...hat.com>
To: nathan.lynch@....com,
	Basavaraj.Natikar@....com,
	vkoul@...nel.org,
	dmaengine@...r.kernel.org,
	linux-kernel@...r.kernel.org
Cc: Eder Zulian <ezulian@...hat.com>
Subject: [PATCH v2] dmaengine: ptdma: Remove unused pointer dma_cmd_cache

The pointer 'struct kmem_cache *dma_cmd_cache' was introduced in commit
'b0b4a6b10577 ("dmaengine: ptdma: register PTDMA controller as a DMA
resource")' but it was never used.

Changes since v1:
- Remove the 'err_cache' label and return -ENOMEM directly instead of
  assigning -ENOMEM to 'ret' and jumping to the label, since there
  are no unmanaged allocations to unwind. Based on suggestion from
  Nathan Lynch.
- Fix checkpatch.pl error: ERROR: Please use git commit description style
  'commit <12+ chars of sha1> ("<title line>")'

Signed-off-by: Eder Zulian <ezulian@...hat.com>
---
V1 -> V2: Addressed review comments and fix error detected by
checkpatch.pl.

 drivers/dma/amd/ptdma/ptdma-dmaengine.c | 16 ++++------------
 drivers/dma/amd/ptdma/ptdma.h           |  1 -
 2 files changed, 4 insertions(+), 13 deletions(-)

diff --git a/drivers/dma/amd/ptdma/ptdma-dmaengine.c b/drivers/dma/amd/ptdma/ptdma-dmaengine.c
index 3a8014fb9cb4..aefb91c29bb5 100644
--- a/drivers/dma/amd/ptdma/ptdma-dmaengine.c
+++ b/drivers/dma/amd/ptdma/ptdma-dmaengine.c
@@ -583,18 +583,14 @@ int pt_dmaengine_register(struct pt_device *pt)
 	desc_cache_name = devm_kasprintf(pt->dev, GFP_KERNEL,
 					 "%s-dmaengine-desc-cache",
 					 dev_name(pt->dev));
-	if (!desc_cache_name) {
-		ret = -ENOMEM;
-		goto err_cache;
-	}
+	if (!desc_cache_name)
+		return -ENOMEM;
 
 	pt->dma_desc_cache = kmem_cache_create(desc_cache_name,
 					       sizeof(struct pt_dma_desc), 0,
 					       SLAB_HWCACHE_ALIGN, NULL);
-	if (!pt->dma_desc_cache) {
-		ret = -ENOMEM;
-		goto err_cache;
-	}
+	if (!pt->dma_desc_cache)
+		return -ENOMEM;
 
 	dma_dev->dev = pt->dev;
 	dma_dev->src_addr_widths = DMA_SLAVE_BUSWIDTH_64_BYTES;
@@ -648,9 +644,6 @@ int pt_dmaengine_register(struct pt_device *pt)
 err_reg:
 	kmem_cache_destroy(pt->dma_desc_cache);
 
-err_cache:
-	kmem_cache_destroy(pt->dma_cmd_cache);
-
 	return ret;
 }
 EXPORT_SYMBOL_GPL(pt_dmaengine_register);
@@ -662,5 +655,4 @@ void pt_dmaengine_unregister(struct pt_device *pt)
 	dma_async_device_unregister(dma_dev);
 
 	kmem_cache_destroy(pt->dma_desc_cache);
-	kmem_cache_destroy(pt->dma_cmd_cache);
 }
diff --git a/drivers/dma/amd/ptdma/ptdma.h b/drivers/dma/amd/ptdma/ptdma.h
index 0a7939105e51..ef3f55632107 100644
--- a/drivers/dma/amd/ptdma/ptdma.h
+++ b/drivers/dma/amd/ptdma/ptdma.h
@@ -254,7 +254,6 @@ struct pt_device {
 	/* Support for the DMA Engine capabilities */
 	struct dma_device dma_dev;
 	struct pt_dma_chan *pt_dma_chan;
-	struct kmem_cache *dma_cmd_cache;
 	struct kmem_cache *dma_desc_cache;
 
 	wait_queue_head_t lsb_queue;
-- 
2.49.0