linux-kernel - Re: [PATCH v2] dmaengine: ptdma: Remove unused pointer dma_cmd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87plhckvdn.fsf@AUSNATLYNCH.amd.com>
Date: Wed, 16 Apr 2025 09:56:36 -0500
From: Nathan Lynch <nathan.lynch@....com>
To: Eder Zulian <ezulian@...hat.com>, <Basavaraj.Natikar@....com>,
	<vkoul@...nel.org>, <dmaengine@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
CC: Eder Zulian <ezulian@...hat.com>
Subject: Re: [PATCH v2] dmaengine: ptdma: Remove unused pointer dma_cmd_cache

Eder Zulian <ezulian@...hat.com> writes:
> The pointer 'struct kmem_cache *dma_cmd_cache' was introduced in commit
> 'b0b4a6b10577 ("dmaengine: ptdma: register PTDMA controller as a DMA
> resource")' but it was never used.
>
> Changes since v1:
> - Remove the 'err_cache' label and return -ENOMEM directly instead of
>   assigning -ENOMEM to 'ret' and jumping to the label, since there
>   are no unmanaged allocations to unwind. Based on suggestion from
>   Nathan Lynch.
> - Fix checkpatch.pl error: ERROR: Please use git commit description style
>   'commit <12+ chars of sha1> ("<title line>")'
>
> Signed-off-by: Eder Zulian <ezulian@...hat.com>

Reviewed-by: Nathan Lynch <nathan.lynch@....com>