linux-kernel - Re: [PATCH v2] pinctrl: amd: Fix use of undeclared identifier 'pinctrl_amd_s2idle_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0h_Qc2xukPMmwHr-E1HvMwSoLT4TM96aV0e9QKfeRSGGQ@mail.gmail.com>
Date: Tue, 15 Apr 2025 15:37:18 +0200
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Linus Walleij <linus.walleij@...aro.org>
Cc: Mario Limonciello <superm1@...nel.org>, "Rafael J . Wysocki" <rjw@...ysocki.net>, 
	"open list:PIN CONTROL SUBSYSTEM" <linux-gpio@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>, 
	linux-acpi@...r.kernel.org, Basavaraj Natikar <Basavaraj.Natikar@....com>, 
	Shyam Sundar S K <Shyam-sundar.S-k@....com>, Mario Limonciello <mario.limonciello@....com>, 
	kernel test robot <lkp@...el.com>
Subject: Re: [PATCH v2] pinctrl: amd: Fix use of undeclared identifier 'pinctrl_amd_s2idle_dev_ops'

On Tue, Apr 15, 2025 at 3:34 PM Linus Walleij <linus.walleij@...aro.org> wrote:
>
> On Mon, Apr 14, 2025 at 10:35 PM Mario Limonciello <superm1@...nel.org> wrote:
>
> > From: Mario Limonciello <mario.limonciello@....com>
> >
> > `pinctrl_amd_s2idle_dev_ops` is hidden under both `CONFIG_ACPI` and
> > `CONFIG_PM_SLEEP` so the functions that use it need the same scope.
> >
> > Adjust checks to look for both, and while updating make it CONFIG_SUSPEND
> > instead as that's what the acpi header uses.
> >
> > Reported-by: kernel test robot <lkp@...el.com>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202504100420.88UPkUTU-lkp@intel.com/
> > Signed-off-by: Mario Limonciello <mario.limonciello@....com>
> > ---
> > v2:
> >  Use CONFIG_SUSPEND instead of CONFIG_PM_SLEEP
>
> This seems to be based on the previous fixes merged by Rafael?
>
> Do I need to rebase on -rc2 or something to merge this patch?
>
> Or can Rafael queue this too?

I can.

> In that case:
> Acked-by: Linus Walleij <linus.walleij@...aro.org>

Thanks!