linux-kernel - Re: [PATCH v2] pinctrl: amd: Fix use of undeclared identifier 'pinctrl_amd_s2idle_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6f7c9675-e86c-4d61-9d47-d92a9746b693@kernel.org>
Date: Tue, 15 Apr 2025 08:37:11 -0500
From: Mario Limonciello <superm1@...nel.org>
To: Linus Walleij <linus.walleij@...aro.org>
Cc: "Rafael J . Wysocki" <rjw@...ysocki.net>,
 "open list:PIN CONTROL SUBSYSTEM" <linux-gpio@...r.kernel.org>,
 open list <linux-kernel@...r.kernel.org>, linux-acpi@...r.kernel.org,
 Basavaraj Natikar <Basavaraj.Natikar@....com>,
 Shyam Sundar S K <Shyam-sundar.S-k@....com>,
 Mario Limonciello <mario.limonciello@....com>,
 kernel test robot <lkp@...el.com>
Subject: Re: [PATCH v2] pinctrl: amd: Fix use of undeclared identifier
 'pinctrl_amd_s2idle_dev_ops'

On 4/15/2025 8:34 AM, Linus Walleij wrote:
> On Mon, Apr 14, 2025 at 10:35 PM Mario Limonciello <superm1@...nel.org> wrote:
> 
>> From: Mario Limonciello <mario.limonciello@....com>
>>
>> `pinctrl_amd_s2idle_dev_ops` is hidden under both `CONFIG_ACPI` and
>> `CONFIG_PM_SLEEP` so the functions that use it need the same scope.
>>
>> Adjust checks to look for both, and while updating make it CONFIG_SUSPEND
>> instead as that's what the acpi header uses.
>>
>> Reported-by: kernel test robot <lkp@...el.com>
>> Closes: https://lore.kernel.org/oe-kbuild-all/202504100420.88UPkUTU-lkp@intel.com/
>> Signed-off-by: Mario Limonciello <mario.limonciello@....com>
>> ---
>> v2:
>>   Use CONFIG_SUSPEND instead of CONFIG_PM_SLEEP
> 
> This seems to be based on the previous fixes merged by Rafael?
> 
> Do I need to rebase on -rc2 or something to merge this patch?
> 
> Or can Rafael queue this too?
> In that case:
> Acked-by: Linus Walleij <linus.walleij@...aro.org>
> 
> Yours,
> Linus Walleij

Yeah; I think Rafael should take it as the other patches are in his 
tree.  No other pinctrl-amd stuff planned this cycle that I know about.

Thanks!