linux-kernel - RE: [PATCH v4 11/36] x86/bugs: Restructure spectre_v2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <LV3PR12MB9265B894CD18006C074CDD4194B22@LV3PR12MB9265.namprd12.prod.outlook.com>
Date: Tue, 15 Apr 2025 14:56:46 +0000
From: "Kaplan, David" <David.Kaplan@....com>
To: Josh Poimboeuf <jpoimboe@...nel.org>
CC: Thomas Gleixner <tglx@...utronix.de>, Borislav Petkov <bp@...en8.de>,
	Peter Zijlstra <peterz@...radead.org>, Pawan Gupta
	<pawan.kumar.gupta@...ux.intel.com>, Ingo Molnar <mingo@...hat.com>, Dave
 Hansen <dave.hansen@...ux.intel.com>, "x86@...nel.org" <x86@...nel.org>, "H .
 Peter Anvin" <hpa@...or.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, Brendan Jackman <jackmanb@...gle.com>, Derek
 Manwaring <derekmn@...zon.com>
Subject: RE: [PATCH v4 11/36] x86/bugs: Restructure spectre_v2_user mitigation

[AMD Official Use Only - AMD Internal Distribution Only]

> -----Original Message-----
> From: Josh Poimboeuf <jpoimboe@...nel.org>
> Sent: Monday, April 14, 2025 6:49 PM
> To: Kaplan, David <David.Kaplan@....com>
> Cc: Thomas Gleixner <tglx@...utronix.de>; Borislav Petkov <bp@...en8.de>;
> Peter Zijlstra <peterz@...radead.org>; Pawan Gupta
> <pawan.kumar.gupta@...ux.intel.com>; Ingo Molnar <mingo@...hat.com>; Dave
> Hansen <dave.hansen@...ux.intel.com>; x86@...nel.org; H . Peter Anvin
> <hpa@...or.com>; linux-kernel@...r.kernel.org; Brendan Jackman
> <jackmanb@...gle.com>; Derek Manwaring <derekmn@...zon.com>
> Subject: Re: [PATCH v4 11/36] x86/bugs: Restructure spectre_v2_user mitigation
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> On Mon, Apr 14, 2025 at 07:20:59PM +0000, Kaplan, David wrote:
> > [AMD Official Use Only - AMD Internal Distribution Only]
> >
> > > -----Original Message-----
> > > From: Josh Poimboeuf <jpoimboe@...nel.org>
> > > Sent: Thursday, April 10, 2025 11:41 AM
> > > To: Kaplan, David <David.Kaplan@....com>
> > > Cc: Thomas Gleixner <tglx@...utronix.de>; Borislav Petkov
> > > <bp@...en8.de>; Peter Zijlstra <peterz@...radead.org>; Pawan Gupta
> > > <pawan.kumar.gupta@...ux.intel.com>; Ingo Molnar <mingo@...hat.com>;
> > > Dave Hansen <dave.hansen@...ux.intel.com>; x86@...nel.org; H . Peter
> > > Anvin <hpa@...or.com>; linux-kernel@...r.kernel.org; Brendan Jackman
> > > <jackmanb@...gle.com>; Derek Manwaring <derekmn@...zon.com>
> > > Subject: Re: [PATCH v4 11/36] x86/bugs: Restructure spectre_v2_user
> > > mitigation
> > >
> > > Caution: This message originated from an External Source. Use proper
> > > caution when opening attachments, clicking links, or responding.
> > >
> > >
> > > On Mon, Mar 10, 2025 at 11:39:58AM -0500, David Kaplan wrote:
> > > > @@ -214,6 +211,8 @@ void __init cpu_select_mitigations(void)
> > > >        * choices.
> > > >        */
> > > >       retbleed_update_mitigation();
> > > > +     /* spectre_v2_user_update_mitigation() depends on retbleed_mitigation
> */
> > > > +     spectre_v2_user_update_mitigation();
> > >
> > > Function names need trailing parentheses: "retbleed_mitigation()"
> > >
> >
> > That one is not actually a function name, it's the name of the file-scope variable.
>
> Why refer to a variable?  Isn't it the function dependencies which matter here?
>

Yeah, I agree.  The variable is what gets checked in the dependent function, but given this code block is all about the order of these various function calls, then using a function name makes more sense.

--David Kaplan