linux-kernel - Re: [RESEND PATCH] gpio: vf610: Allow building as a module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkda23XbwhWTXzEF54D6yupc8+xAQpSPPb2vAy9aQsXxe+A@mail.gmail.com>
Date: Tue, 15 Apr 2025 23:46:00 +0200
From: Linus Walleij <linus.walleij@...aro.org>
To: Jindong Yue <jindong.yue@....com>
Cc: brgl@...ev.pl, linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH] gpio: vf610: Allow building as a module

On Tue, Apr 8, 2025 at 5:15 PM Jindong Yue <jindong.yue@....com> wrote:

> Support for building it as a module for use on the Android
> platform, because the Android kernel(GKI) doesn't contain
> board-specific drivers, it requires that these drivers
> be built as a module and loaded into the system.
>
> Signed-off-by: Jindong Yue <jindong.yue@....com>
(...)

>  builtin_platform_driver(vf610_gpio_driver);
> +MODULE_DESCRIPTION("VF610 GPIO driver");
> +MODULE_LICENSE("GPL");

You compile a builtin_platform_driver() and then claim this is
a module?

Switch the builtin_platform_driver() to module_platform_driver().

(Also make sure that removing the module actually works, please.)

Yours,
Linus Walleij