linux-kernel - RE: [EXT] Re: [RESEND PATCH] gpio: vf610: Allow building as a module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <GV1PR04MB9183B5A58F5C2B51A2B9C82AFBBD2@GV1PR04MB9183.eurprd04.prod.outlook.com>
Date: Wed, 16 Apr 2025 06:31:43 +0000
From: Jindong Yue <jindong.yue@....com>
To: Linus Walleij <linus.walleij@...aro.org>
CC: "brgl@...ev.pl" <brgl@...ev.pl>, "linux-gpio@...r.kernel.org"
	<linux-gpio@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [EXT] Re: [RESEND PATCH] gpio: vf610: Allow building as a module

> -----Original Message-----
> From: Linus Walleij <linus.walleij@...aro.org>
> Sent: Wednesday, April 16, 2025 5:46 AM
> To: Jindong Yue <jindong.yue@....com>
> Cc: brgl@...ev.pl; linux-gpio@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: [EXT] Re: [RESEND PATCH] gpio: vf610: Allow building as a module
> 
> 
> 
> On Tue, Apr 8, 2025 at 5:15 PM Jindong Yue <jindong.yue@....com> wrote:
> 
> > Support for building it as a module for use on the Android platform,
> > because the Android kernel(GKI) doesn't contain board-specific
> > drivers, it requires that these drivers be built as a module and
> > loaded into the system.
> >
> > Signed-off-by: Jindong Yue <jindong.yue@....com>
> (...)
> 
> >  builtin_platform_driver(vf610_gpio_driver);
> > +MODULE_DESCRIPTION("VF610 GPIO driver"); MODULE_LICENSE("GPL");
> 
> You compile a builtin_platform_driver() and then claim this is a module?
> 
> Switch the builtin_platform_driver() to module_platform_driver().
> 
> (Also make sure that removing the module actually works, please.)
> 
Thanks for your review. I just sent patch v2 to use module_platform_driver().
I also verified that with this change, the module can be removed and reinstalled on the running system.

BRs,
Jindong