linux-kernel - Re: [tip: core/urgent] compiler.h: Avoid the usage of __typeof_unqual__() when __GENKSYMS_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFULd4YOGgH39+Fge=N3M0jKzchg36005ZYss_qPD_0qzQ2scg@mail.gmail.com>
Date: Tue, 15 Apr 2025 08:16:51 +0200
From: Uros Bizjak <ubizjak@...il.com>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: Ingo Molnar <mingo@...nel.org>, Thomas Gleixner <tglx@...utronix.de>, 
	Linus Torvalds <torvalds@...ux-foundation.org>, Borislav Petkov <bp@...en8.de>, 
	linux-kernel@...r.kernel.org, linux-tip-commits@...r.kernel.org, 
	Paul Menzel <pmenzel@...gen.mpg.de>, x86@...nel.org
Subject: Re: [tip: core/urgent] compiler.h: Avoid the usage of
 __typeof_unqual__() when __GENKSYMS__ is defined

On Tue, Apr 15, 2025 at 3:20 AM Andrew Morton <akpm@...ux-foundation.org> wrote:
>
> On Sun, 13 Apr 2025 21:20:00 +0200 Ingo Molnar <mingo@...nel.org> wrote:
>
> > > > > If this commit is removed, [...]
> > > >
> > > > I did not remove commit ac053946f5c4, it's already upstream. Nor
> > > > did I advocate for it to be reverted - I'd like it to be fixed. So
> > > > you are barking up the wrong tree.
> > >
> > > If the intention is to pass my proposed workaround via Andrew's tree,
> > > then I'm happy to bark up the wrong tree, but from the referred
> > > message trail, I didn't get the clear decision about the patch, and
> > > neither am sure which patch "brown paper bag bug" refers to.
> >
> > It's up to akpm (he merged your original patch that regressed), but I
> > think scripts/genksyms/ should be fixed instead of worked around -
> > which is why I zapped the workaround.
>
> I'm OK with the original workaround - super simple and fixes the issue.
> I don't know if Borislav intends to upstream this, so I'll grab a copy
> also.
>
> Nobody has commented on Uros's more recent alteration to genksyms
> (https://lkml.kernel.org/r/CAFULd4aLMF_2AbUAvpYw+o1qo6U-Ya_+Ewy-wW17g-r-MBF9_g@mail.gmail.com)?
>
> Uros, please persist with that approach and hopefully we'll have a
> patch which removes the temporary workaround.

The genksyms patch was posted as formal patch submission at [1] and
was accepted to -tip tree. The genksyms patch obsoletes compiler.h
patch [2], so there is no need for compiler.h change anymore.

[1] https://lore.kernel.org/lkml/20250413220749.270704-1-ubizjak@gmail.com/
[2] https://lore.kernel.org/all/CAFULd4aLMF_2AbUAvpYw+o1qo6U-Ya_+Ewy-wW17g-r-MBF9_g@mail.gmail.com/

Thanks,
Uros.