linux-kernel - Re: [tip: core/urgent] compiler.h: Avoid the usage of __typeof_unqual__() when __GENKSYMS_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250414182057.fe2fc32273ca1520c9b5dd4d@linux-foundation.org>
Date: Mon, 14 Apr 2025 18:20:57 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Ingo Molnar <mingo@...nel.org>
Cc: Uros Bizjak <ubizjak@...il.com>, Thomas Gleixner <tglx@...utronix.de>,
 Linus Torvalds <torvalds@...ux-foundation.org>, Borislav Petkov
 <bp@...en8.de>, linux-kernel@...r.kernel.org,
 linux-tip-commits@...r.kernel.org, Paul Menzel <pmenzel@...gen.mpg.de>,
 x86@...nel.org
Subject: Re: [tip: core/urgent] compiler.h: Avoid the usage of
 __typeof_unqual__() when __GENKSYMS__ is defined

On Sun, 13 Apr 2025 21:20:00 +0200 Ingo Molnar <mingo@...nel.org> wrote:

> > > > If this commit is removed, [...]
> > >
> > > I did not remove commit ac053946f5c4, it's already upstream. Nor 
> > > did I advocate for it to be reverted - I'd like it to be fixed. So 
> > > you are barking up the wrong tree.
> > 
> > If the intention is to pass my proposed workaround via Andrew's tree, 
> > then I'm happy to bark up the wrong tree, but from the referred 
> > message trail, I didn't get the clear decision about the patch, and 
> > neither am sure which patch "brown paper bag bug" refers to.
> 
> It's up to akpm (he merged your original patch that regressed), but I 
> think scripts/genksyms/ should be fixed instead of worked around - 
> which is why I zapped the workaround.

I'm OK with the original workaround - super simple and fixes the issue.
I don't know if Borislav intends to upstream this, so I'll grab a copy
also.

Nobody has commented on Uros's more recent alteration to genksyms
(https://lkml.kernel.org/r/CAFULd4aLMF_2AbUAvpYw+o1qo6U-Ya_+Ewy-wW17g-r-MBF9_g@mail.gmail.com)?

Uros, please persist with that approach and hopefully we'll have a
patch which removes the temporary workaround.