linux-kernel - Re: [PATCH v3] serial: sifive: lock port in startup()/shutdown() callbacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <84r01tooq9.fsf@jogness.linutronix.de>
Date: Tue, 15 Apr 2025 09:48:06 +0206
From: John Ogness <john.ogness@...utronix.de>
To: Ryo Takakura <ryotkkr98@...il.com>, alex@...ti.fr,
 aou@...s.berkeley.edu, bigeasy@...utronix.de, conor.dooley@...rochip.com,
 gregkh@...uxfoundation.org, jirislaby@...nel.org, palmer@...belt.com,
 paul.walmsley@...ive.com, pmladek@...e.com, samuel.holland@...ive.com,
 u.kleine-koenig@...libre.com
Cc: linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org,
 linux-serial@...r.kernel.org, stable@...r.kernel.org, Ryo Takakura
 <ryotkkr98@...il.com>
Subject: Re: [PATCH v3] serial: sifive: lock port in startup()/shutdown()
 callbacks

On 2025-04-12, Ryo Takakura <ryotkkr98@...il.com> wrote:
> startup()/shutdown() callbacks access SIFIVE_SERIAL_IE_OFFS.
> The register is also accessed from write() callback.
>
> If console were printing and startup()/shutdown() callback
> gets called, its access to the register could be overwritten.
>
> Add port->lock to startup()/shutdown() callbacks to make sure
> their access to SIFIVE_SERIAL_IE_OFFS is synchronized against
> write() callback.
>
> Fixes: 45c054d0815b ("tty: serial: add driver for the SiFive UART")
> Signed-off-by: Ryo Takakura <ryotkkr98@...il.com>
> Reviewed-by: Petr Mladek <pmladek@...e.com>

Reviewed-by: John Ogness <john.ogness@...utronix.de>