linux-kernel - Re: [PATCH v3] serial: sifive: lock port in startup()/shutdown() callbacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20250415104453.3690-1-ryotkkr98@gmail.com>
Date: Tue, 15 Apr 2025 19:44:53 +0900
From: Ryo Takakura <ryotkkr98@...il.com>
To: john.ogness@...utronix.de
Cc: alex@...ti.fr,
	aou@...s.berkeley.edu,
	bigeasy@...utronix.de,
	conor.dooley@...rochip.com,
	gregkh@...uxfoundation.org,
	jirislaby@...nel.org,
	linux-kernel@...r.kernel.org,
	linux-riscv@...ts.infradead.org,
	linux-serial@...r.kernel.org,
	palmer@...belt.com,
	paul.walmsley@...ive.com,
	pmladek@...e.com,
	ryotkkr98@...il.com,
	samuel.holland@...ive.com,
	stable@...r.kernel.org,
	u.kleine-koenig@...libre.com
Subject: Re: [PATCH v3] serial: sifive: lock port in startup()/shutdown() callbacks

On Tue, 15 Apr 2025 09:48:06 +0206, John Ogness wrote:
>On 2025-04-12, Ryo Takakura <ryotkkr98@...il.com> wrote:
>> startup()/shutdown() callbacks access SIFIVE_SERIAL_IE_OFFS.
>> The register is also accessed from write() callback.
>>
>> If console were printing and startup()/shutdown() callback
>> gets called, its access to the register could be overwritten.
>>
>> Add port->lock to startup()/shutdown() callbacks to make sure
>> their access to SIFIVE_SERIAL_IE_OFFS is synchronized against
>> write() callback.
>>
>> Fixes: 45c054d0815b ("tty: serial: add driver for the SiFive UART")
>> Signed-off-by: Ryo Takakura <ryotkkr98@...il.com>
>> Reviewed-by: Petr Mladek <pmladek@...e.com>
>
>Reviewed-by: John Ogness <john.ogness@...utronix.de>

I'll add for v4, Thank you John!

Sincerely,
Ryo Takakura