linux-kernel - Re: [PATCH V2 05/10] arm64: dts: imx8mn-beacon: Set SAI5 MCLK direction to output for HDMI audio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z//By2dRIgM1gIx/@lizhi-Precision-Tower-5810>
Date: Wed, 16 Apr 2025 10:42:19 -0400
From: Frank Li <Frank.li@....com>
To: Adam Ford <aford173@...il.com>
Cc: linux-arm-kernel@...ts.infradead.org, aford@...conembedded.com,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>, devicetree@...r.kernel.org,
	imx@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2 05/10] arm64: dts: imx8mn-beacon: Set SAI5 MCLK
 direction to output for HDMI audio

On Tue, Apr 15, 2025 at 08:01:31PM -0500, Adam Ford wrote:
> The HDMI bridge chip fails to generate an audio source due to the SAI5
> master clock (MCLK) direction not being set to output. This prevents proper
> clocking of the HDMI audio interface.
>
> Add the `fsl,sai-mclk-direction-output` property to the SAI5 node to ensure
> the MCLK is driven by the SoC, resolving the HDMI sound issue.
>
> Fixes: 1d6880ceef43 ("arm64: dts: imx8mn-beacon: Add HDMI video with sound")
> Signed-off-by: Adam Ford <aford173@...il.com>
> ---
> V2:  Change commit message, no active changes.

Reviewed-by: Frank Li <Frank.Li@....com>

>
>  arch/arm64/boot/dts/freescale/imx8mn-beacon-kit.dts | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mn-beacon-kit.dts b/arch/arm64/boot/dts/freescale/imx8mn-beacon-kit.dts
> index 1df5ceb11387..37fc5ed98d7f 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mn-beacon-kit.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mn-beacon-kit.dts
> @@ -124,6 +124,7 @@ &sai5 {
>  	assigned-clock-parents = <&clk IMX8MN_AUDIO_PLL1_OUT>;
>  	assigned-clock-rates = <24576000>;
>  	#sound-dai-cells = <0>;
> +	fsl,sai-mclk-direction-output;
>  	status = "okay";
>  };
>
> --
> 2.48.1
>