linux-kernel - Re: [PATCH] scatterlist: inline sg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250416170053.GA189808@quark.localdomain>
Date: Wed, 16 Apr 2025 10:00:53 -0700
From: Eric Biggers <ebiggers@...nel.org>
To: Caleb Sander Mateos <csander@...estorage.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
	linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scatterlist: inline sg_next()

On Wed, Apr 16, 2025 at 10:06:13AM -0600, Caleb Sander Mateos wrote:
> sg_next() is a short function called frequently in I/O paths. Define it
> in the header file so it can be inlined into its callers.
> 
> Signed-off-by: Caleb Sander Mateos <csander@...estorage.com>

Reviewed-by: Eric Biggers <ebiggers@...nel.org>

I had been thinking about doing this too.  Besides the benefits for storage,
this will also reduce the overhead in some parts of the crypto subsystem.

> Is it a concern that this would break kernel modules built against old headers?
> If so, I could update the patch to continue compiling and exporting sg_next() in
> scatterlist.c.

No, that's not a concern.

- Eric