linux-kernel - Re: [PATCH] scatterlist: inline sg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250416150529.1e24677e3798cd783f4adb8f@linux-foundation.org>
Date: Wed, 16 Apr 2025 15:05:29 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Caleb Sander Mateos <csander@...estorage.com>
Cc: linux-mm@...ck.org, linux-block@...r.kernel.org,
 linux-kernel@...r.kernel.org, Eric Biggers <ebiggers@...nel.org>
Subject: Re: [PATCH] scatterlist: inline sg_next()

On Wed, 16 Apr 2025 10:06:13 -0600 Caleb Sander Mateos <csander@...estorage.com> wrote:

> sg_next() is a short function called frequently in I/O paths. Define it
> in the header file so it can be inlined into its callers.

Does this actually make anything faster?

net/ceph/messenger_v2.c has four calls to sg_next().  x86_64 defconfig:

x1:/usr/src/25> size net/ceph/messenger_v2.o
   text	   data	    bss	    dec	    hex	filename
  31486	   2212	      0	  33698	   83a2	net/ceph/messenger_v2.o

after:

  31742	   2212	      0	  33954	   84a2	net/ceph/messenger_v2.o

More text means more cache misses.  Possibly the patch slows things down??