linux-kernel - [PATCH] bus: mhi: host: pci_generic: Remove assign resource usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250416-remove_assin_resource-v1-1-e92dd361fa0a@quicinc.com>
Date: Wed, 16 Apr 2025 10:49:51 +0530
From: Subramanian Ananthanarayanan <quic_skananth@...cinc.com>
To: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
CC: <mhi@...ts.linux.dev>, <linux-arm-msm@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>,
        Subramanian Ananthanarayanan
	<quic_skananth@...cinc.com>
Subject: [PATCH] bus: mhi: host: pci_generic: Remove assign resource usage

Avoid redundant usage of pci_assign_resource for BAR allocation.
This is already taken care by PCIe framework. Invocation of this
API leads to unnecessary relocation of BAR space to a new memory
address.

Signed-off-by: Subramanian Ananthanarayanan <quic_skananth@...cinc.com>
---
 drivers/bus/mhi/host/pci_generic.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/bus/mhi/host/pci_generic.c b/drivers/bus/mhi/host/pci_generic.c
index 03aa88795209..7501abc835c7 100644
--- a/drivers/bus/mhi/host/pci_generic.c
+++ b/drivers/bus/mhi/host/pci_generic.c
@@ -996,10 +996,6 @@ static int mhi_pci_claim(struct mhi_controller *mhi_cntrl,
 	struct pci_dev *pdev = to_pci_dev(mhi_cntrl->cntrl_dev);
 	int err;
 
-	err = pci_assign_resource(pdev, bar_num);
-	if (err)
-		return err;
-
 	err = pcim_enable_device(pdev);
 	if (err) {
 		dev_err(&pdev->dev, "failed to enable pci device: %d\n", err);

---
base-commit: 5b37f7bfff3b1582c34be8fb23968b226db71ebd
change-id: 20250416-remove_assin_resource-aa0db88d02eb

Best regards,
-- 
Subramanian Ananthanarayanan <quic_skananth@...cinc.com>