linux-kernel - Re: [PATCH next] pwm: loongson: Fix an error code in probe()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7apoevpcxrsi7u345otb6cna3k3khhiwlmoitgilu6f3bv6mtb@jdvlox57u3cu>
Date: Wed, 16 Apr 2025 07:24:18 +0200
From: Uwe Kleine-König <ukleinek@...nel.org>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Binbin Zhou <zhoubinbin@...ngson.cn>, 
	Huacai Chen <chenhuacai@...nel.org>, Juxin Gao <gaojuxin@...ngson.cn>, linux-pwm@...r.kernel.org, 
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH next] pwm: loongson: Fix an error code in probe()

Hello Dan,

On Wed, Apr 09, 2025 at 02:00:20PM +0300, Dan Carpenter wrote:
> There is a copy and paste bug so we accidentally returned
> PTR_ERR(ddata->clk) instead of "ret".
> 
> Fixes: 322fc380cea1 ("pwm: Add Loongson PWM controller support")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---
>  drivers/pwm/pwm-loongson.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pwm/pwm-loongson.c b/drivers/pwm/pwm-loongson.c
> index 412c67739ef9..e31afb11ddd7 100644
> --- a/drivers/pwm/pwm-loongson.c
> +++ b/drivers/pwm/pwm-loongson.c
> @@ -211,7 +211,7 @@ static int pwm_loongson_probe(struct platform_device *pdev)
>  	if (ddata->clk) {
>  		ret = devm_clk_rate_exclusive_get(dev, ddata->clk);
>  		if (ret)
> -			return dev_err_probe(dev, PTR_ERR(ddata->clk),
> +			return dev_err_probe(dev, ret,
>  					     "Failed to get exclusive rate\n");
>  
>  		ddata->clk_rate = clk_get_rate(ddata->clk);

How embarrassing that I didn't spot that during review. Thanks for the
fix!

Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git pwm/for-next
with Binbin's Reviewed-by tag.

Best regards
Uwe

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)