linux-kernel - Re: [PATCH] arm64: dts: Fix nuvoton 8xx clock properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <79400920-22b4-4bce-b204-c58087495c22@kernel.org>
Date: Wed, 16 Apr 2025 08:55:11 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: "William A. Kennington III" <william@...nnington.com>,
 Avi Fishman <avifishman70@...il.com>, Tomer Maimon <tmaimon77@...il.com>,
 Tali Perry <tali.perry1@...il.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Cc: openbmc@...ts.ozlabs.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: Fix nuvoton 8xx clock properties

On 16/04/2025 01:25, William A. Kennington III wrote:
> The latest iteration of the clock driver got rid of the separate clock

I don't see the binding deprecated.

> compatible node, merging clock and reset devices.
> 
> Signed-off-by: William A. Kennington III <william@...nnington.com>
> ---
>  .../boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi | 16 ++++++----------
>  .../boot/dts/nuvoton/nuvoton-npcm845-evb.dts     |  8 ++++++++
>  2 files changed, 14 insertions(+), 10 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi b/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
> index ecd171b2feba..4da62308b274 100644
> --- a/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
> +++ b/arch/arm64/boot/dts/nuvoton/nuvoton-common-npcm8xx.dtsi
> @@ -47,17 +47,13 @@ ahb {
>  		interrupt-parent = <&gic>;
>  		ranges;
>  
> -		rstc: reset-controller@...01000 {
> +		clk: rstc: reset-controller@...01000 {
>  			compatible = "nuvoton,npcm845-reset";
>  			reg = <0x0 0xf0801000 0x0 0x78>;

So now it lacks quite a bit of address space. This must be explained in
commit msg.

>  			#reset-cells = <2>;
>  			nuvoton,sysgcr = <&gcr>;
> -		};
> -
> -		clk: clock-controller@...01000 {
> -			compatible = "nuvoton,npcm845-clk";
> +			clocks = <&refclk>;
>  			#clock-cells = <1>;
> -			reg = <0x0 0xf0801000 0x0 0x1000>;
>  		};
>  
>  		apb {
> @@ -81,7 +77,7 @@ timer0: timer@...0 {
>  				compatible = "nuvoton,npcm845-timer";
>  				interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>;
>  				reg = <0x8000 0x1C>;
> -				clocks = <&clk NPCM8XX_CLK_REFCLK>;
> +				clocks = <&refclk>;

Not explained in commit msg.

Best regards,
Krzysztof