linux-kernel - Re: [PATCH] gpio: nomadik: Add check for clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdZqyTphs0k6k2tOXwYzT_K=Jbt7h1CZX1Rh-2LDjWhxcQ@mail.gmail.com>
Date: Wed, 16 Apr 2025 10:35:06 +0200
From: Linus Walleij <linus.walleij@...aro.org>
To: Chenyuan Yang <chenyuan0y@...il.com>
Cc: Théo Lebrun <theo.lebrun@...tlin.com>, brgl@...ev.pl, 
	linux-arm-kernel@...ts.infradead.org, linux-gpio@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] gpio: nomadik: Add check for clk_enable()

On Mon, Apr 14, 2025 at 2:11 PM Chenyuan Yang <chenyuan0y@...il.com> wrote:
> On Mon, Apr 14, 2025 at 4:24 AM Théo Lebrun <theo.lebrun@...tlin.com> wrote:

> > Seeing the __irq_startup() code, my proposal would be to turn the return
> > value to a signed int, but I haven't exhaustively checked codepaths.
>
> Good catch! I agree that using a signed int could be a better option.
>
> Dear Linus and Bartosz, could you please share your thoughts? If
> you’re on board with the change, I’ll go ahead and send a new patch.

Yeah that would be great, thanks!

Thanks for noticing this as well Theo, I think your team is the
most important user of this code right now.

Yours,
Linus Walleij