linux-kernel - Re: [PATCH] gpio: nomadik: Add check for clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMRc=Md+w7Wp8gS=PvpYkz6z4y45z6QiO7A0i24ESSa8N_byeg@mail.gmail.com>
Date: Mon, 14 Apr 2025 20:30:40 +0200
From: Bartosz Golaszewski <brgl@...ev.pl>
To: Chenyuan Yang <chenyuan0y@...il.com>
Cc: Théo Lebrun <theo.lebrun@...tlin.com>, 
	linus.walleij@...aro.org, linux-arm-kernel@...ts.infradead.org, 
	linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] gpio: nomadik: Add check for clk_enable()

On Mon, Apr 14, 2025 at 2:11 PM Chenyuan Yang <chenyuan0y@...il.com> wrote:
>
> On Mon, Apr 14, 2025 at 4:24 AM Théo Lebrun <theo.lebrun@...tlin.com> wrote:
> >
> > As for why irq_startup returns an unsigned int, I am unsure. The kernel
> > Git history isn't enough to know more. The startup field in struct
> > hw_interrupt_type appeared on v2.3.14 [2], so no commit message to
> > explain decisions.
> >
> > Seeing the __irq_startup() code, my proposal would be to turn the return
> > value to a signed int, but I haven't exhaustively checked codepaths.
>
> Good catch! I agree that using a signed int could be a better option.
>
> Dear Linus and Bartosz, could you please share your thoughts? If
> you’re on board with the change, I’ll go ahead and send a new patch.
>

Ok, I'm backing out this one then.

Bartosz