linux-kernel - Re: [PATCH v1 4/7] gpiolib: Call validate_desc() when VALIDATE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z_9-YCWKVaXqsJ2N@smile.fi.intel.com>
Date: Wed, 16 Apr 2025 12:54:40 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Linus Walleij <linus.walleij@...aro.org>
Cc: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
	linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
	Bartosz Golaszewski <brgl@...ev.pl>
Subject: Re: [PATCH v1 4/7] gpiolib: Call validate_desc() when
 VALIDATE_DESC() can't be used

On Wed, Apr 16, 2025 at 12:17:11PM +0300, Andy Shevchenko wrote:
> On Wed, Apr 16, 2025 at 10:44:18AM +0200, Linus Walleij wrote:
> > On Tue, Apr 15, 2025 at 1:11 PM Andy Shevchenko
> > <andriy.shevchenko@...ux.intel.com> wrote:

...

> > >         if (gc->to_irq) {
> > > -               int retirq = gc->to_irq(gc, offset);
> > > +               ret = gc->to_irq(gc, offset);
> > > +               if (ret)
> > > +                       return ret;
> > >
> > >                 /* Zero means NO_IRQ */
> > > -               if (!retirq)
> > > -                       return -ENXIO;
> > > -
> > > -               return retirq;
> > > +               return -ENXIO;
> > 
> > Totally unrelated change - but I'm fine with that :D
> 
> It's not totally (it's a reuse of the same variable), but I can split it.
> Bart, what do you prefer?
Never mind, I will send a v2 soon.

Linus, I will leave your Rb tag in a split patch as it seems you've reviewed it
as a whole already.

-- 
With Best Regards,
Andy Shevchenko