linux-kernel - Re: [PATCH 6/7] drm/bridge: analogix_dp: ignore return values of drm_panel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <693a5c6a-88b3-4f52-b918-ef78ff174c1f@linaro.org>
Date: Thu, 17 Apr 2025 17:48:58 +0200
From: Neil Armstrong <neil.armstrong@...aro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>,
 Andrzej Hajda <andrzej.hajda@...el.com>, Robert Foss <rfoss@...nel.org>,
 Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
 Jonas Karlman <jonas@...boo.se>, Jernej Skrabec <jernej.skrabec@...il.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 Jessica Zhang <quic_jesszhan@...cinc.com>
Cc: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 6/7] drm/bridge: analogix_dp: ignore return values of
 drm_panel_* calls

On 01/04/2025 07:11, Dmitry Baryshkov wrote:
> Follow the example of other drivers and ignore return values of the
> drm_panel_prepare() / unprepare() / enable() / disable() calls. There is
> no possible error recovery, so the driver just logs a message.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
> ---
>   drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 39 ++++------------------
>   1 file changed, 6 insertions(+), 33 deletions(-)
> 
> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> index f60068011008482f7b7b2edfcab5fb1b3e9e130f..c7dffdae31877ae194fc6b0a5bf21be203f7dcc4 100644
> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> @@ -838,10 +838,7 @@ static int analogix_dp_commit(struct analogix_dp_device *dp)
>   	int ret;
>   
>   	/* Keep the panel disabled while we configure video */
> -	if (dp->plat_data->panel) {
> -		if (drm_panel_disable(dp->plat_data->panel))
> -			DRM_ERROR("failed to disable the panel\n");
> -	}
> +	drm_panel_disable(dp->plat_data->panel);
>   
>   	ret = analogix_dp_train_link(dp);
>   	if (ret) {
> @@ -863,13 +860,7 @@ static int analogix_dp_commit(struct analogix_dp_device *dp)
>   	}
>   
>   	/* Safe to enable the panel now */
> -	if (dp->plat_data->panel) {
> -		ret = drm_panel_enable(dp->plat_data->panel);
> -		if (ret) {
> -			DRM_ERROR("failed to enable the panel\n");
> -			return ret;
> -		}
> -	}
> +	drm_panel_enable(dp->plat_data->panel);
>   
>   	/* Check whether panel supports fast training */
>   	ret = analogix_dp_fast_link_train_detection(dp);
> @@ -1136,7 +1127,6 @@ static void analogix_dp_bridge_atomic_pre_enable(struct drm_bridge *bridge,
>   	struct analogix_dp_device *dp = bridge->driver_private;
>   	struct drm_crtc *crtc;
>   	struct drm_crtc_state *old_crtc_state;
> -	int ret;
>   
>   	crtc = analogix_dp_get_new_crtc(dp, old_state);
>   	if (!crtc)
> @@ -1147,11 +1137,7 @@ static void analogix_dp_bridge_atomic_pre_enable(struct drm_bridge *bridge,
>   	if (old_crtc_state && old_crtc_state->self_refresh_active)
>   		return;
>   
> -	if (dp->plat_data->panel) {
> -		ret = drm_panel_prepare(dp->plat_data->panel);
> -		if (ret)
> -			DRM_ERROR("failed to prepare the panel ret = %d\n", ret);
> -	}
> +	drm_panel_prepare(dp->plat_data->panel);
>   }
>   
>   static int analogix_dp_set_bridge(struct analogix_dp_device *dp)
> @@ -1231,17 +1217,11 @@ static void analogix_dp_bridge_atomic_enable(struct drm_bridge *bridge,
>   static void analogix_dp_bridge_disable(struct drm_bridge *bridge)
>   {
>   	struct analogix_dp_device *dp = bridge->driver_private;
> -	int ret;
>   
>   	if (dp->dpms_mode != DRM_MODE_DPMS_ON)
>   		return;
>   
> -	if (dp->plat_data->panel) {
> -		if (drm_panel_disable(dp->plat_data->panel)) {
> -			DRM_ERROR("failed to disable the panel\n");
> -			return;
> -		}
> -	}
> +	drm_panel_disable(dp->plat_data->panel);
>   
>   	disable_irq(dp->irq);
>   
> @@ -1249,11 +1229,7 @@ static void analogix_dp_bridge_disable(struct drm_bridge *bridge)
>   
>   	pm_runtime_put_sync(dp->dev);
>   
> -	if (dp->plat_data->panel) {
> -		ret = drm_panel_unprepare(dp->plat_data->panel);
> -		if (ret)
> -			DRM_ERROR("failed to unprepare the panel ret = %d\n", ret);
> -	}
> +	drm_panel_unprepare(dp->plat_data->panel);
>   
>   	dp->fast_train_enable = false;
>   	dp->psr_supported = false;
> @@ -1678,10 +1654,7 @@ void analogix_dp_unbind(struct analogix_dp_device *dp)
>   	analogix_dp_bridge_disable(dp->bridge);
>   	dp->connector.funcs->destroy(&dp->connector);
>   
> -	if (dp->plat_data->panel) {
> -		if (drm_panel_unprepare(dp->plat_data->panel))
> -			DRM_ERROR("failed to turnoff the panel\n");
> -	}
> +	drm_panel_unprepare(dp->plat_data->panel);
>   
>   	drm_dp_aux_unregister(&dp->aux);
>   
> 

Reviewed-by: Neil Armstrong <neil.armstrong@...aro.org>