linux-kernel - Re: [PATCH 0/7] drm/panel: make prepare / enable / disable / unprepare return void

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <107cd28d-bdb4-4b59-83e4-4b85dce97290@linaro.org>
Date: Fri, 18 Apr 2025 15:22:39 +0200
From: Neil Armstrong <neil.armstrong@...aro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>,
 Andrzej Hajda <andrzej.hajda@...el.com>, Robert Foss <rfoss@...nel.org>,
 Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
 Jonas Karlman <jonas@...boo.se>, Jernej Skrabec <jernej.skrabec@...il.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 Jessica Zhang <quic_jesszhan@...cinc.com>
Cc: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/7] drm/panel: make prepare / enable / disable /
 unprepare return void

On 01/04/2025 07:11, Dmitry Baryshkov wrote:
> While it makes sense for panel callbacks to be able to return an error,
> the state-management functions from drm_panel API are usually called
> from atomic callbacks, which can not fails and must return void. Make
> drm_panel_prepare(), drm_panel_enable(), drm_panel_disable() and
> drm_panel_unprepare() follow the same calling convention and return
> void.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
> ---
> Dmitry Baryshkov (7):
>        drm/bridge: analogix_dp: drop extra calls to analogix_dp_prepare_panel()
>        drm/bridge: analogix_dp: drop unused argument to analogix_dp_prepare_panel()
>        drm/bridge: analogic_dp: drop panel_is_modeset
>        drm/bridge: analogic_dp: drop panel_lock
>        drm/bridge: analogix_dp: inline analogix_dp_prepare_panel()
>        drm/bridge: analogix_dp: ignore return values of drm_panel_* calls
>        drm/panel: make prepare/enable and disable/unprepare calls return void
> 
>   drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 107 ++-------------------
>   drivers/gpu/drm/bridge/analogix/analogix_dp_core.h |   3 -
>   drivers/gpu/drm/drm_panel.c                        |  54 ++++-------
>   drivers/gpu/drm/panel/panel-newvision-nv3051d.c    |   9 +-
>   include/drm/drm_panel.h                            |   8 +-
>   5 files changed, 33 insertions(+), 148 deletions(-)
> ---
> base-commit: bfb20a655848a9088e3e9ae24b1dcce1bbf016c2
> change-id: 20250401-panel-return-void-d461c71ebd35
> 
> Best regards,

I think you can respin with the warning fix on patch 1 and then apply

Neil