| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAP-5=fXxxaBs_JGqZVM8rZzg837Po4_p2wOARBj2i6183kXgjA@mail.gmail.com>
Date: Thu, 17 Apr 2025 16:12:16 -0700
From: Ian Rogers <irogers@...gle.com>
To: Arnaldo Carvalho de Melo <acme@...nel.org>
Cc: arnaldo.melo@...il.com, Namhyung Kim <namhyung@...nel.org>,
Adrian Hunter <adrian.hunter@...el.com>, James Clark <james.clark@...aro.org>,
Jiri Olsa <jolsa@...nel.org>, Kan Liang <kan.liang@...ux.intel.com>,
Quentin Monnet <qmo@...nel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
linux-perf-users@...r.kernel.org
Subject: Re: [PATCH 1/1] tools build: Remove libbfd from the set of expected
libraries to build perf
On Thu, Apr 17, 2025 at 2:58 PM Arnaldo Carvalho de Melo
<acme@...nel.org> wrote:
> > There is a wider set of cleanups that remove BUILD_NONDISTRO and
> > libbfd that I posted back in January:
> > https://lore.kernel.org/lkml/20250122174308.350350-1-irogers@google.com/
>
> I thought that discussion hadn't come to a conclusion, then I was in
> vacation in January + LSFMM/BPF, lost track of it, will read your
> message below and look at it again.
>
> Its just that I recreated my toolbox container for building perf to a
> fedora:42 based one and went on trying to build it from the base system
> that gets installed in such containers till the point where I found the
> above problem.
>
> Now doing 'make -C tools/perf build-test' I'm getting this after the
> above patch:
>
> make_nondistro_O: cd . && make BUILD_NONDISTRO=1 FEATURES_DUMP=/home/acme/git/perf-tools-next/tools/perf/BUILD_TEST_FEATURE_DUMP -j32 O=/tmp/tmp.NssFD0ssxu DESTDIR=/tmp/tmp.oEuROiOLtI
> cd . && make BUILD_NONDISTRO=1 FEATURES_DUMP=/home/acme/git/perf-tools-next/tools/perf/BUILD_TEST_FEATURE_DUMP -j32 O=/tmp/tmp.NssFD0ssxu DESTDIR=/tmp/tmp.oEuROiOLtI
> BUILD: Doing 'make -j32' parallel build
> Warning: Kernel ABI header differences:
> diff -u tools/include/uapi/linux/bits.h include/uapi/linux/bits.h
> diff -u tools/include/linux/bits.h include/linux/bits.h
> diff -u tools/include/vdso/unaligned.h include/vdso/unaligned.h
> diff -u tools/arch/arm64/include/asm/cputype.h arch/arm64/include/asm/cputype.h
> Makefile.config:952: Old version of libbfd/binutils things like PE executable profiling will not be available
> Makefile.config:968: No libllvm 13+ found, slower source file resolution, please install llvm-devel/llvm-dev
> Makefile.config:1147: No openjdk development package found, please install JDK package, e.g. openjdk-8-jdk, java-1.8.0-openjdk-devel
>
> GEN /tmp/tmp.NssFD0ssxu/common-cmds.h
> <SNIP>
> In file included from util/disasm_bpf.c:18:
> /home/acme/git/perf-tools-next/tools/include/tools/dis-asm-compat.h:10:6: error: redeclaration of ‘enum disassembler_style’
> 10 | enum disassembler_style {DISASSEMBLER_STYLE_NOT_EMPTY};
> | ^~~~~~~~~~~~~~~~~~
> In file included from util/disasm_bpf.c:15:
> /usr/include/dis-asm.h:53:6: note: originally defined here
> 53 | enum disassembler_style
> | ^~~~~~~~~~~~~~~~~~
> /home/acme/git/perf-tools-next/tools/include/tools/dis-asm-compat.h: In function ‘init_disassemble_info_compat’:
> /home/acme/git/perf-tools-next/tools/include/tools/dis-asm-compat.h:50:9: error: too few arguments to function ‘init_disassemble_info’; expected 4, have 3
> 50 | init_disassemble_info(info, stream,
> | ^~~~~~~~~~~~~~~~~~~~~
> /usr/include/dis-asm.h:482:13: note: declared here
> 482 | extern void init_disassemble_info (struct disassemble_info *dinfo, void *stream,
> | ^~~~~~~~~~~~~~~~~~~~~
> util/disasm_bpf.c: In function ‘symbol__disassemble_bpf’:
> util/disasm_bpf.c:109:36: error: incompatible type for argument 1 of ‘disassembler’
> 109 | disassemble = disassembler(bfdf);
> | ^~~~
> | |
> | bfd *
> /usr/include/dis-asm.h:411:63: note: expected ‘enum bfd_architecture’ but argument is of type ‘bfd *’
> 411 | extern disassembler_ftype disassembler (enum bfd_architecture arc,
> | ~~~~~~~~~~~~~~~~~~~~~~^~~
> util/disasm_bpf.c:109:23: error: too few arguments to function ‘disassembler’; expected 4, have 1
> 109 | disassemble = disassembler(bfdf);
> | ^~~~~~~~~~~~
> /usr/include/dis-asm.h:411:27: note: declared here
> 411 | extern disassembler_ftype disassembler (enum bfd_architecture arc,
> | ^~~~~~~~~~~~
> make[6]: *** [/home/acme/git/perf-tools-next/tools/build/Makefile.build:86: /tmp/tmp.NssFD0ssxu/util/disasm_bpf.o] Error 1
> make[6]: *** Waiting for unfinished jobs....
> CC /tmp/tmp.NssFD0ssxu/bench/mem-memcpy-x86-64-asm.o
> <SNIP>
> make[5]: *** [/home/acme/git/perf-tools-next/tools/build/Makefile.build:142: util] Error 2
> make[4]: *** [Makefile.perf:798: /tmp/tmp.NssFD0ssxu/perf-util-in.o] Error 2
> make[4]: *** Waiting for unfinished jobs....
> LD /tmp/tmp.NssFD0ssxu/tests/workloads/perf-test-in.o
> LD /tmp/tmp.NssFD0ssxu/tests/perf-test-in.o
> LD /tmp/tmp.NssFD0ssxu/perf-test-in.o
> LD /tmp/tmp.NssFD0ssxu/perf-in.o
> CC /tmp/tmp.NssFD0ssxu/pmu-events/pmu-events.o
> LD /tmp/tmp.NssFD0ssxu/pmu-events/pmu-events-in.o
> make[3]: *** [Makefile.perf:290: sub-make] Error 2
> make[2]: *** [Makefile:76: all] Error 2
> make[1]: *** [tests/make:341: make_nondistro_O] Error 1
> make: *** [Makefile:109: build-test] Error 2
> make: Leaving directory '/home/acme/git/perf-tools-next/tools/perf'
Looked like a bad cherry pick, I sent rebased versions of the patches
and an extra small cleanup patch in the v4 patch series:
https://lore.kernel.org/lkml/20250417230740.86048-1-irogers@google.com/
Thanks,
Ian
> - Arnaldo
Powered by blists - more mailing lists