linux-kernel - Re: [PATCH 1/1] tools build: Remove libbfd from the set of expected libraries to build perf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aAJublOL0i5BzrH5@x1>
Date: Fri, 18 Apr 2025 12:23:26 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: Ian Rogers <irogers@...gle.com>
Cc: arnaldo.melo@...il.com, Namhyung Kim <namhyung@...nel.org>,
	Adrian Hunter <adrian.hunter@...el.com>,
	James Clark <james.clark@...aro.org>, Jiri Olsa <jolsa@...nel.org>,
	Kan Liang <kan.liang@...ux.intel.com>,
	Quentin Monnet <qmo@...nel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	linux-perf-users@...r.kernel.org
Subject: Re: [PATCH 1/1] tools build: Remove libbfd from the set of expected
 libraries to build perf

On Thu, Apr 17, 2025 at 04:12:16PM -0700, Ian Rogers wrote:
> On Thu, Apr 17, 2025 at 2:58 PM Arnaldo Carvalho de Melo <acme@...nel.org> wrote:
> > > There is a wider set of cleanups that remove BUILD_NONDISTRO and
> > > libbfd that I posted back in January:
> > > https://lore.kernel.org/lkml/20250122174308.350350-1-irogers@google.com/

> > I thought that discussion hadn't come to a conclusion, then I was in
> > vacation in January + LSFMM/BPF, lost track of it, will read your
> > message below and look at it again.

> > Its just that I recreated my toolbox container for building perf to a
> > fedora:42 based one and went on trying to build it from the base system
> > that gets installed in such containers till the point where I found the
> > above problem.

> > Now doing 'make -C tools/perf build-test' I'm getting this after the
> > above patch:

> >             make_nondistro_O: cd . && make BUILD_NONDISTRO=1 FEATURES_DUMP=/home/acme/git/perf-tools-next/tools/perf/BUILD_TEST_FEATURE_DUMP -j32 O=/tmp/tmp.NssFD0ssxu DESTDIR=/tmp/tmp.oEuROiOLtI
> > cd . && make BUILD_NONDISTRO=1 FEATURES_DUMP=/home/acme/git/perf-tools-next/tools/perf/BUILD_TEST_FEATURE_DUMP -j32 O=/tmp/tmp.NssFD0ssxu DESTDIR=/tmp/tmp.oEuROiOLtI
> >   BUILD:   Doing 'make -j32' parallel build

<SNIP>

> > util/disasm_bpf.c:109:23: error: too few arguments to function ‘disassembler’; expected 4, have 1
> >   109 |         disassemble = disassembler(bfdf);
> >       |                       ^~~~~~~~~~~~
> > /usr/include/dis-asm.h:411:27: note: declared here
> >   411 | extern disassembler_ftype disassembler (enum bfd_architecture arc,
> >       |                           ^~~~~~~~~~~~
> > make[6]: *** [/home/acme/git/perf-tools-next/tools/build/Makefile.build:86: /tmp/tmp.NssFD0ssxu/util/disasm_bpf.o] Error 1
> > make[6]: *** Waiting for unfinished jobs....
> >   CC      /tmp/tmp.NssFD0ssxu/bench/mem-memcpy-x86-64-asm.o
> > <SNIP>

<SNIP>
 
> Looked like a bad cherry pick, I sent rebased versions of the patches

I didn't cherry pick from your series, I mean on what is in
perf-tools-next/perf-tools-next

> and an extra small cleanup patch in the v4 patch series:
> https://lore.kernel.org/lkml/20250417230740.86048-1-irogers@google.com/

Thanks for resending it, I'll test with it.

- Arnaldo