linux-kernel - Re: [PATCH v5 1/5] dt-bindings: leds: add TI/National Semiconductor LP5812 LED Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <878933d0-7062-4b91-ac32-efd5ea190702@kernel.org>
Date: Thu, 17 Apr 2025 07:43:18 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Nam Tran <trannamatk@...il.com>, krzk+dt@...nel.org
Cc: pavel@...nel.org, lee@...nel.org, robh@...nel.org, conor+dt@...nel.org,
 corbet@....net, devicetree@...r.kernel.org, linux-leds@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 1/5] dt-bindings: leds: add TI/National Semiconductor
 LP5812 LED Driver

On 17/04/2025 04:06, Nam Tran wrote:
> 
>>>
>>>>> +
>>>>> +patternProperties:
>>>>> +  "^led@[0-9a-b]$":
>>>>> +    type: object
>>>>> +    $ref: common.yaml#
>>>>> +    unevaluatedProperties: false
>>>>> +
>>>>> +    properties:
>>>>> +      reg:
>>>>> +        minimum: 0
>>>>> +        maximum: 0xb
>>>>> +
>>>>> +      chan-name:
>>>>> +        $ref: /schemas/types.yaml#/definitions/string
>>>>> +        description: LED channel name
>>>>
>>>> My comment stay valid. I don't think LEDs have channels, datasheet also
>>>> has nothing about channels, so again - use existing properties. Or
>>>> better drop it - I don't see any point in the name. The reg already
>>>> defines it.
>>>
>>> The channel was named for the output channel to each LED, not the LED channels.
>>
>> I don't understand what you want to say. Please explain why existing
>> label property is not correct here.
> 
> I understand that the label property is deprecated and that the preferred approach now is to use function and color instead.
> However, in the case of the LP5812, which is a matrix LED driver, these properties are not a good fit.
> The LP5812 does not associate each output with a specific function (like "status", "activity"),
> and the LEDs driven by LP5812 are not fixed to a particular color.

Then use label instead of creating another property. If label is
deprecated, how creating another property which duplicates the label
solves anything?


Best regards,
Krzysztof