linux-kernel - Re: [PATCH v5 1/5] dt-bindings: leds: add TI/National Semiconductor LP5812 LED Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250417093740.8466-1-trannamatk@gmail.com>
Date: Thu, 17 Apr 2025 16:37:40 +0700
From: Nam Tran <trannamatk@...il.com>
To: krzk+dt@...nel.org
Cc: pavel@...nel.org,
	lee@...nel.org,
	robh@...nel.org,
	conor+dt@...nel.org,
	corbet@....net,
	devicetree@...r.kernel.org,
	linux-leds@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 1/5] dt-bindings: leds: add TI/National Semiconductor LP5812 LED Driver

On Thu, 17 Apr 2025, Krzysztof Kozlowski wrote:

>On 17/04/2025 04:06, Nam Tran wrote:
>> 
>>>>
>>>>>> +
>>>>>> +patternProperties:
>>>>>> +  "^led@[0-9a-b]$":
>>>>>> +    type: object
>>>>>> +    $ref: common.yaml#
>>>>>> +    unevaluatedProperties: false
>>>>>> +
>>>>>> +    properties:
>>>>>> +      reg:
>>>>>> +        minimum: 0
>>>>>> +        maximum: 0xb
>>>>>> +
>>>>>> +      chan-name:
>>>>>> +        $ref: /schemas/types.yaml#/definitions/string
>>>>>> +        description: LED channel name
>>>>>
>>>>> My comment stay valid. I don't think LEDs have channels, datasheet also
>>>>> has nothing about channels, so again - use existing properties. Or
>>>>> better drop it - I don't see any point in the name. The reg already
>>>>> defines it.
>>>>
>>>> The channel was named for the output channel to each LED, not the LED channels.
>>>
>>> I don't understand what you want to say. Please explain why existing
>>> label property is not correct here.
>> 
>> I understand that the label property is deprecated and that the preferred approach now is to use function and color instead.
>> However, in the case of the LP5812, which is a matrix LED driver, these properties are not a good fit.
>> The LP5812 does not associate each output with a specific function (like "status", "activity"),
>> and the LEDs driven by LP5812 are not fixed to a particular color.
>
>Then use label instead of creating another property. If label is
>deprecated, how creating another property which duplicates the label
>solves anything?

You're right — creating a new property like chan-name does not help
if it duplicates the purpose of the deprecated label property.
I initially created the chan-name property after referring to the existing leds-lp55xx.yaml binding.

However, based on your recommendation, I’ve decided to drop chan-name and the entire subnode as well.
Additionally, I will add the vcc-supply property as mentioned in the last email.

Would this be sufficient for me to submit a new patch?

Best regards,
Nam Tran