linux-kernel - Re: [PATCH v6 09/10] arm64: dts: cix: add initial CIX P1(SKY1) dts support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <74b9fc25-0815-4ece-845a-5f730c87fe78@kernel.org>
Date: Thu, 17 Apr 2025 08:18:44 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Peter Chen <peter.chen@...tech.com>, soc@...nel.org, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, catalin.marinas@....com,
 will@...nel.org, arnd@...db.de, jassisinghbrar@...il.com
Cc: linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, cix-kernel-upstream@...tech.com,
 maz@...nel.org, kajetan.puchalski@....com,
 Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
 Fugang Duan <fugang.duan@...tech.com>, Guomin Chen
 <Guomin.Chen@...tech.com>, Gary Yang <gary.yang@...tech.com>
Subject: Re: [PATCH v6 09/10] arm64: dts: cix: add initial CIX P1(SKY1) dts
 support

On 15/04/2025 09:27, Peter Chen wrote:
> +
> +		mbox_ap2pm: mailbox@...0080 {
> +			compatible = "cix,sky1-mbox";
> +			reg = <0x0 0x06590080 0x0 0xff80>;
> +			interrupts = <GIC_SPI 363 IRQ_TYPE_LEVEL_HIGH 0>;
> +			#mbox-cells = <1>;
> +			cix,mbox-dir = "tx";
> +		};
> +
> +		pm2ap_scmi_mem: pm2ap-shmem@...0000 {
> +			compatible = "arm,scmi-shmem";
> +			#address-cells = <2>;
> +			#size-cells = <2>;
> +			reg-io-width = <4>;
> +			reg = <0x0 0x065a0000 0x0 0x80>;

Messed order of properties. Keep it consistent (see DTS conding style).
Other nodes also have oddly placed reg.



Best regards,
Krzysztof