linux-kernel - Re: [PATCH v6 09/10] arm64: dts: cix: add initial CIX P1(SKY1) dts support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cef48ecc-94b6-40a0-9f9c-a616814878fb@kernel.org>
Date: Thu, 17 Apr 2025 08:19:59 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Peter Chen <peter.chen@...tech.com>, soc@...nel.org, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, catalin.marinas@....com,
 will@...nel.org, arnd@...db.de, jassisinghbrar@...il.com
Cc: linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, cix-kernel-upstream@...tech.com,
 maz@...nel.org, kajetan.puchalski@....com,
 Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
 Fugang Duan <fugang.duan@...tech.com>, Guomin Chen
 <Guomin.Chen@...tech.com>, Gary Yang <gary.yang@...tech.com>
Subject: Re: [PATCH v6 09/10] arm64: dts: cix: add initial CIX P1(SKY1) dts
 support

On 15/04/2025 09:27, Peter Chen wrote:
> CIX SKY1 SoC is high performance Armv9 SoC designed by Cixtech,
> and Orion O6 is the motherboard launched by Radxa. See below for
> detail:
> https://docs.radxa.com/en/orion/o6/getting-started/introduction
> 
> In this commit, it adds sky1 base, mailbox, clock (scmi firmware baseed)
> and uart, and the kernel could boot up to console.
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

You added several new device nodes, so obviously this is not true anymore.

This is explained in submitting patches - you must drop the review when
making substantial changes. Adding several nodes is a substantial change.

> Acked-by: Fugang Duan <fugang.duan@...tech.com>

And this as well



Best regards,
Krzysztof