linux-kernel - Re: [PATCH 6/6] mt8395-radxa-nio-12l: Add sound node for headphone

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a87a22b3-b263-4044-ab89-54c805fcc82a@collabora.com>
Date: Thu, 17 Apr 2025 12:20:38 +0200
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
To: Julien Massot <julien.massot@...labora.com>, kernel@...labora.com,
 Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
 Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
 Matthias Brugger <matthias.bgg@...il.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Trevor Wu <trevor.wu@...iatek.com>
Cc: linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org,
 devicetree@...r.kernel.org
Subject: Re: [PATCH 6/6] mt8395-radxa-nio-12l: Add sound node for headphone

Il 17/04/25 10:44, Julien Massot ha scritto:
> - Add memory-region based on mt8390-genio-common
> - Enable adsp node
> - Enable afe node
> - Declare the required pins
> - Add sound node for headphone output routing
> 
> Signed-off-by: Julien Massot <julien.massot@...labora.com>

Please stick with the usual prefixes.

arm64: dts: mediatek: mt8395-nio-12l: Enable Audio DSP and sound card

Also, the commit description should not be a list of things, but rather
something that explains what you're doing fluently.

"Add a memory region for xyz, enable the Audio DSP and AFE nodes and
assign them to the newly enabled sound card node along with the required
pin configuration to achieve sound output to the 3.5mm headphone jack
found on this board."

Reword to your liking, that was just an example.

Cheers,
Angelo

> ---
>   .../boot/dts/mediatek/mt8395-radxa-nio-12l.dts     | 58 +++++++++++++++++++++-
>   1 file changed, 56 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts b/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts
> index f2eb1b683eb76f783f5a13f28a78f6e33238b5f0..329c60cc6a6be0b4be8c0b8bb033b32d35302804 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt8395-radxa-nio-12l.dts
> @@ -139,9 +139,21 @@ bl31_secmon_mem: memory@...00000 {
>   			no-map;
>   		};
>   
> -		afe_mem: memory@...00000 {
> +		adsp_mem: memory@...00000 {
>   			compatible = "shared-dma-pool";
> -			reg = <0 0x60000000 0 0x1100000>;
> +			reg = <0 0x60000000 0 0xf00000>;
> +			no-map;
> +		};
> +
> +		afe_dma_mem: memory@...00000 {
> +			compatible = "shared-dma-pool";
> +			reg = <0 0x60f00000 0 0x100000>;
> +			no-map;
> +		};
> +
> +		adsp_dma_mem: memory@...00000 {
> +			compatible = "shared-dma-pool";
> +			reg = <0 0x61000000 0 0x100000>;
>   			no-map;
>   		};
>   
> @@ -152,6 +164,16 @@ apu_mem: memory@...00000 {
>   	};
>   };
>   
> +&adsp {
> +	memory-region = <&adsp_dma_mem>, <&adsp_mem>;
> +	status = "okay";
> +};
> +
> +&afe {
> +	memory-region = <&afe_dma_mem>;
> +	status = "okay";
> +};
> +
>   &cpu0 {
>   	cpu-supply = <&mt6359_vcore_buck_reg>;
>   };
> @@ -514,6 +536,18 @@ &mt6359_vsram_others_ldo_reg {
>   &pio {
>   	mediatek,rsel-resistance-in-si-unit;
>   
> +	audio_default_pins: audio-default-pins {
> +		pins-cmd-dat {
> +			pinmux = <PINMUX_GPIO70__FUNC_AUD_SYNC_MOSI>,
> +				 <PINMUX_GPIO69__FUNC_AUD_CLK_MOSI>,
> +				 <PINMUX_GPIO71__FUNC_AUD_DAT_MOSI0>,
> +				 <PINMUX_GPIO72__FUNC_AUD_DAT_MOSI1>,
> +				 <PINMUX_GPIO73__FUNC_AUD_DAT_MISO0>,
> +				 <PINMUX_GPIO74__FUNC_AUD_DAT_MISO1>,
> +				 <PINMUX_GPIO75__FUNC_AUD_DAT_MISO2>;
> +		};
> +	};
> +
>   	dsi0_backlight_pins: dsi0-backlight-pins {
>   		pins-backlight-en {
>   			pinmux = <PINMUX_GPIO107__FUNC_GPIO107>;
> @@ -854,6 +888,26 @@ &scp {
>   	status = "okay";
>   };
>   
> +&sound {
> +	compatible = "mediatek,mt8195_mt6359";
> +	model = "mt8395-evk";
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&audio_default_pins>;
> +	audio-routing =
> +		"Headphone", "Headphone L",
> +		"Headphone", "Headphone R";
> +	mediatek,adsp = <&adsp>;
> +	status = "okay";
> +
> +	headphone-dai-link {
> +		link-name = "DL_SRC_BE";
> +
> +		codec {
> +			sound-dai = <&pmic 0>;
> +		};
> +	};
> +};
> +
>   &spi1 {
>   	/* Exposed at 40 pin connector */
>   	pinctrl-0 = <&spi1_pins>;
>