linux-kernel - Re: [PATCH wireless-next v6 6/9] wifi: mwifiex: simplify mwifiex_setup_ht

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aADVuz/ctBmJNRU/@nxpwireless-Inspiron-14-Plus-7440>
Date: Thu, 17 Apr 2025 18:19:39 +0800
From: Jeff Chen <jeff.chen_1@....com>
To: Sascha Hauer <s.hauer@...gutronix.de>
Cc: Brian Norris <briannorris@...omium.org>,
	Francesco Dolcini <francesco@...cini.it>,
	Johannes Berg <johannes.berg@...el.com>,
	linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
	David Lin <yu-hao.lin@....com>, kernel@...gutronix.de
Subject: Re: [PATCH wireless-next v6 6/9] wifi: mwifiex: simplify
 mwifiex_setup_ht_caps()

On Thu, Apr 10, 2025 at 12:24:30 PM +0200, Sascha Hauer wrote:
> In mwifiex_setup_ht_caps() first a local struct ieee80211_mcs_info
> is initialized and afterwards copied over &ht_info->mcs. Simplify
> this by initializing &ht_info->mcs directly.
> 
> While at it call memset on the u8 rx_mask[] array instead of the struct
> which makes the intention clearer and we no longer have to assume the
> rx_mask array is the first member of struct ieee80211_mcs_info.
> 
> Signed-off-by: Sascha Hauer <s.hauer@...gutronix.de>
> Acked-by: Brian Norris <briannorris@...omium.org>

Reviewed-by: Jeff Chen <jeff.chen_1@....com>