linux-kernel - Re: [PATCH v3 05/32] selftests: harness: Remove inline qualifier for wrappers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8204b57b-45c8-40e6-a936-915e8c45f3e4@collabora.com>
Date: Fri, 18 Apr 2025 22:00:59 +0500
From: Muhammad Usama Anjum <usama.anjum@...labora.com>
To: Thomas Weißschuh <thomas.weissschuh@...utronix.de>,
 Shuah Khan <shuah@...nel.org>, Shuah Khan <skhan@...uxfoundation.org>,
 Willy Tarreau <w@....eu>, Thomas Weißschuh
 <linux@...ssschuh.net>, Kees Cook <kees@...nel.org>
Cc: Andy Lutomirski <luto@...capital.net>, Will Drewry <wad@...omium.org>,
 linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH v3 05/32] selftests: harness: Remove inline qualifier for
 wrappers

On 4/11/25 2:00 PM, Thomas Weißschuh wrote:
> The pointers to the wrappers are stored in function pointers,
> preventing them from actually being inlined.
> Remove the inline qualifier, aligning these wrappers with the other
> functions defined through macros.
> 
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@...utronix.de>
Reviewed-by: Muhammad Usama Anjum <usama.anjum@...labora.com>

> ---
>  tools/testing/selftests/kselftest_harness.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/kselftest_harness.h b/tools/testing/selftests/kselftest_harness.h
> index 5822bc0b86a3c623fd34830fb8b541b27672a00b..222a4f51a8d704c41597e09a241ad887ef787139 100644
> --- a/tools/testing/selftests/kselftest_harness.h
> +++ b/tools/testing/selftests/kselftest_harness.h
> @@ -172,7 +172,7 @@
>  
>  #define __TEST_IMPL(test_name, _signal) \
>  	static void test_name(struct __test_metadata *_metadata); \
> -	static inline void wrapper_##test_name( \
> +	static void wrapper_##test_name( \
>  		struct __test_metadata *_metadata, \
>  		struct __fixture_variant_metadata __attribute__((unused)) *variant) \
>  	{ \
> @@ -401,7 +401,7 @@
>  		struct __test_metadata *_metadata, \
>  		FIXTURE_DATA(fixture_name) *self, \
>  		const FIXTURE_VARIANT(fixture_name) *variant); \
> -	static inline void wrapper_##fixture_name##_##test_name( \
> +	static void wrapper_##fixture_name##_##test_name( \
>  		struct __test_metadata *_metadata, \
>  		struct __fixture_variant_metadata *variant) \
>  	{ \
> 


-- 
Regards,
Usama