linux-kernel - Re: [PATCH v3 06/32] selftests: harness: Remove dependency on libatomic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <447d6f10-a04b-4492-8cc0-cac317f7c6c7@collabora.com>
Date: Fri, 18 Apr 2025 22:16:42 +0500
From: Muhammad Usama Anjum <usama.anjum@...labora.com>
To: Thomas Weißschuh <thomas.weissschuh@...utronix.de>,
 Shuah Khan <shuah@...nel.org>, Shuah Khan <skhan@...uxfoundation.org>,
 Willy Tarreau <w@....eu>, Thomas Weißschuh
 <linux@...ssschuh.net>, Kees Cook <kees@...nel.org>
Cc: Andy Lutomirski <luto@...capital.net>, Will Drewry <wad@...omium.org>,
 linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH v3 06/32] selftests: harness: Remove dependency on
 libatomic

On 4/11/25 2:00 PM, Thomas Weißschuh wrote:
> __sync_bool_compare_and_swap() is deprecated and requires libatomic on
> GCC. Compiler toolchains don't necessarily have libatomic available, so
> avoid this requirement by using atomics that don't need libatomic.
> 
> Signed-off-by: Thomas Weißschuh <thomas.weissschuh@...utronix.de>
Reviewed-by: Muhammad Usama Anjum <usama.anjum@...labora.com>

> ---
>  tools/testing/selftests/kselftest_harness.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/kselftest_harness.h b/tools/testing/selftests/kselftest_harness.h
> index 222a4f51a8d704c41597e09a241ad887ef787139..7ec4f66d0e3d7f129f6c2a45ff58310dabe5d03f 100644
> --- a/tools/testing/selftests/kselftest_harness.h
> +++ b/tools/testing/selftests/kselftest_harness.h
> @@ -439,12 +439,12 @@
>  		} \
>  		if (child == 0) { \
>  			if (_metadata->setup_completed && !fixture_name##_teardown_parent && \
> -					__sync_bool_compare_and_swap(teardown, false, true)) \
> +					!__atomic_test_and_set(teardown, __ATOMIC_RELAXED)) \
>  				fixture_name##_teardown(_metadata, self, variant->data); \
>  			_exit(0); \
>  		} \
>  		if (_metadata->setup_completed && fixture_name##_teardown_parent && \
> -				__sync_bool_compare_and_swap(teardown, false, true)) \
> +				!__atomic_test_and_set(teardown, __ATOMIC_RELAXED)) \
>  			fixture_name##_teardown(_metadata, self, variant->data); \
>  		munmap(teardown, sizeof(*teardown)); \
>  		if (self && fixture_name##_teardown_parent) \
> 


-- 
Regards,
Usama