linux-kernel - Re: [PATCH] be2net: Remove potential access to the zero address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250417195453.2f3260aa@kernel.org>
Date: Thu, 17 Apr 2025 19:54:53 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
Cc: Ваторопин Андрей
 <a.vatoropin@...t.ru>, Ajit Khaparde <ajit.khaparde@...adcom.com>,
 Sriharsha Basavapatna <sriharsha.basavapatna@...adcom.com>, Somnath Kotur
 <somnath.kotur@...adcom.com>, Andrew Lunn <andrew+netdev@...n.ch>, "David
 S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo
 Abeni <pabeni@...hat.com>, Padmanabh Ratnakar
 <padmanabh.ratnakar@...lex.com>, Mammatha Edhala
 <mammatha.edhala@...lex.com>, "netdev@...r.kernel.org"
 <netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org"
 <linux-kernel@...r.kernel.org>, "lvc-project@...uxtesting.org"
 <lvc-project@...uxtesting.org>
Subject: Re: [PATCH] be2net: Remove potential access to the zero address

On Wed, 16 Apr 2025 13:32:29 +0200 Michal Swiatkowski wrote:
> > At the moment of calling the function be_cmd_get_mac_from_list() with the
> > following parameters:
> > be_cmd_get_mac_from_list(adapter, mac, &pmac_valid, NULL, 
> > 					adapter->if_handle, 0);  
> 
> Looks like pmac_valid needs to be false to reach *pmac_id assign.

Right, it is for this caller and there is a check which skip this logic
if pmac_id_valid is false, line 3738.