linux-kernel - Re: [PATCH -v2 00/10] timers: Simple cleanup of the timer API namespace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aAH_xCECRV75M6ON@gmail.com>
Date: Fri, 18 Apr 2025 09:31:16 +0200
From: Ingo Molnar <mingo@...nel.org>
To: linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>
Cc: Thomas Gleixner <tglx@...utronix.de>,
	Frederic Weisbecker <frederic@...nel.org>,
	"H . Peter Anvin" <hpa@...or.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH -v2 00/10] timers: Simple cleanup of the timer API
 namespace


* Ingo Molnar <mingo@...nel.org> wrote:

> [ Changes since -v1:
>    - Exclude the 6 APIs that need further work, keep 9 APIs/symbols
>    - timer_init_on_stack_key() -> timer_init_key_on_stack()
>    - Fixes
>    - Rebase to -rc2
> ]

> Ingo Molnar (10):
>   rust: Rename timer_container_of() to hrtimer_container_of()
>   treewide, timers: Rename from_timer() => timer_container_of()
>   treewide, timers: Rename try_to_del_timer_sync() => timer_delete_sync_try()
>   treewide, timers: Rename destroy_timer_on_stack() => timer_destroy_on_stack()
>   treewide, timers: Rename init_timer_key() => timer_init_key()
>   treewide, timers: Rename init_timer_on_stack_key() => timer_init_key_on_stack()
>   treewide, timers: Rename __init_timer() => __timer_init()
>   treewide, timers: Rename __init_timer_on_stack() => __timer_init_on_stack()
>   treewide, timers: Rename NEXT_TIMER_MAX_DELTA => TIMER_NEXT_MAX_DELTA
>   treewide, timers: Rename init_timers() => timers_init()

>  708 files changed, 997 insertions(+), 997 deletions(-)

Thomas, if these changes are broadly acceptable to you as a first step, 
I'd like to propose the following merge order:

These 7 patches with a low -next cross section could go into 
tip:timer/core the regular way, if they pass review & testing:

  rust: Rename timer_container_of() to hrtimer_container_of()
     5 files changed, 6 insertions(+), 6 deletions(-)

  timers: Rename init_timer_key() => timer_init_key()
     2 files changed, 8 insertions(+), 8 deletions(-)

  timers: Rename init_timer_on_stack_key() => timer_init_key_on_stack()
     2 files changed, 6 insertions(+), 6 deletions(-)

  timers: Rename __init_timer() => __timer_init()
     2 files changed, 4 insertions(+), 4 deletions(-)

  timers: Rename __init_timer_on_stack() => __timer_init_on_stack()
     2 files changed, 4 insertions(+), 4 deletions(-)

  timers: Rename NEXT_TIMER_MAX_DELTA => TIMER_NEXT_MAX_DELTA
     3 files changed, 11 insertions(+), 11 deletions(-)

  timers: Rename init_timers() => timers_init()
     3 files changed, 3 insertions(+), 3 deletions(-)

( Note that I've removed the 'treewide' prefix for these patches, as 
  these really are mostly timer subsystem internal changes. )

The three largest changes, which patches I've already ordered to be at 
the tail of the series in the latest mingo/tip.git/WIP.timers/core 
tree, would go to Linus separately, two days before -rc1 or so, 
assuming everything passes review & testing:

  treewide, timers: Rename try_to_del_timer_sync() => timer_delete_sync_try()
     7 files changed, 17 insertions(+), 17 deletions(-)

  treewide, timers: Rename destroy_timer_on_stack() => timer_destroy_on_stack()
     26 files changed, 35 insertions(+), 35 deletions(-)

  treewide, timers: Rename from_timer() => timer_container_of()
     697 files changed, 923 insertions(+), 923 deletions(-)

In addition to this I'll also work on the timer_start_*() API cleanup & 
restructuring you suggested. Please send me the prelimary cocci script 
you had for this that you mentioned in the previous mail and I'll try 
dusting it all off. (Or I'll write new scripts if you cannot find 
them.)

Thanks,

	Ingo