linux-kernel - Re: [PATCH 01/10] rust: Rename timer_container_of() to hrtimer_container

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <877c3cbdq2.fsf@kernel.org>
Date: Tue, 22 Apr 2025 14:08:37 +0200
From: Andreas Hindborg <a.hindborg@...nel.org>
To: "Ingo Molnar" <mingo@...nel.org>
Cc: <linux-kernel@...r.kernel.org>,  "Thomas Gleixner" <tglx@...utronix.de>,
  "Frederic Weisbecker" <frederic@...nel.org>,  "H . Peter Anvin"
 <hpa@...or.com>,  "Linus Torvalds" <torvalds@...ux-foundation.org>,
  "Peter Zijlstra" <peterz@...radead.org>,  "Alex Gaynor"
 <alex.gaynor@...il.com>,  "Anna-Maria Behnsen" <anna-maria@...utronix.de>,
  "Boqun Feng" <boqun.feng@...il.com>,  "Lyude Paul" <lyude@...hat.com>,
  "Miguel Ojeda" <ojeda@...nel.org>
Subject: Re: [PATCH 01/10] rust: Rename timer_container_of() to
 hrtimer_container_of()

Hi Ingo,

"Ingo Molnar" <mingo@...nel.org> writes:

> This primitive is dealing with 'struct hrtimer' objects, not
> 'struct timer_list' objects - so clarify the name.
>
> We want to introduce the timer_container_of() symbol in the kernel
> for timer_list, make sure there's no clash of namespaces, at least
> on the conceptual plane.

This associated trait function is defined on the trait `HasHrTimer`, so
I don't think there is any risk of confusing it with the C (or future
Rust) `timer_container_of` methods/functions.

As to symbol names, there is no risk of conflicts. The rust symbols are
mangled and get quite long.

If you really want this change it's OK with me, but I would prefer to
drop it.

Best regards,
Andreas Hindborg