linux-kernel - Re: [PATCH] openrisc: Fix build warning in cache.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aAIDfcZ4XD5f6mA4@antec>
Date: Fri, 18 Apr 2025 08:47:09 +0100
From: Stafford Horne <shorne@...il.com>
To: Sahil Siddiq <icegambit91@...il.com>
Cc: jonas@...thpole.se, stefan.kristiansson@...nalahti.fi,
	sahilcdq@...ton.me, linux-openrisc@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] openrisc: Fix build warning in cache.c

On Fri, Apr 04, 2025 at 10:39:22AM +0530, Sahil Siddiq wrote:
> Hi Stafford,
> 
> On 4/3/25 7:36 PM, Stafford Horne wrote:
> > [...]
> > I will just take this fix and apply it to the series (git fixup) rather than
> > take this patch as is.  Also, as registers should be unsigned short, I think
> > we should change the type to that.
> > 
> > I will fixup patches in place.
> > 
> 
> Sure thing. Will you be changing the register types as well in place with this
> fix? Let me know if I should send v2 of this patch so the changes are together.

Hi Sahil,

Sorry for delay in getting back on this.  I was working on getting this patches
ready for upstreaming and noticed one thing:

    ---------------------------------------------------------------------------------------
    ./patches/or1k-20250418/0001-openrisc-Refactor-struct-cpuinfo_or1k-to-reduce-dupl.patch
    ---------------------------------------------------------------------------------------
    WARNING: From:/Signed-off-by: email address mismatch: 'From: Sahil Siddiq <icegambit91@...il.com>' != 'Signed-off-by: Sahil Siddiq <sahilcdq@...ton.me>'

    total: 0 errors, 1 warnings, 102 lines checked

As you can see above the scripts/checkpatch.pl is failing with the warning
about your email and signed-off-by not matching.  You can see more about it
in the FROM_SIGN_OFF_MISMATCH section of the checkpatch[0] docs.

How would you like to resolve this?

-Stafford

[0] https://docs.kernel.org/dev-tools/checkpatch.html