linux-kernel - Re: [PATCH v2] cgroup: Fix compilation issue due to cgroup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <af289b54-de43-4d7c-bf74-926abfad7808@oracle.com>
Date: Fri, 18 Apr 2025 13:17:05 +0530
From: Kamalesh Babulal <kamalesh.babulal@...cle.com>
To: gaoxu <gaoxu2@...or.com>, Tejun Heo <tj@...nel.org>,
        Johannes Weiner <hannes@...xchg.org>,
        Michal Koutný
 <mkoutny@...e.com>
Cc: "cgroups@...r.kernel.org" <cgroups@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "surenb@...gle.com" <surenb@...gle.com>,
        yipengxiang <yipengxiang@...or.com>
Subject: Re: [PATCH v2] cgroup: Fix compilation issue due to cgroup_mutex not
 being exported

Hi,

On 4/18/25 8:12 AM, gaoxu wrote:

[...]
> diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c
> index 447ac857e..c1bc51058 100644
> --- a/kernel/cgroup/cgroup.c
> +++ b/kernel/cgroup/cgroup.c
> @@ -84,13 +84,13 @@
>   * css_set_lock protects task->cgroups pointer, the list of css_set
>   * objects, and the chain of tasks off each css_set.
>   *
> - * These locks are exported if CONFIG_PROVE_RCU so that accessors in
> - * cgroup.h can use them for lockdep annotations.
> + * These locks are exported if CONFIG_PROVE_RCU or CONFIG_LOCKDEP so that
> + * accessors in cgroup.h can use them for lockdep annotations.
>   */

Tejun has already merged the initial version of the patch without
the updated description. You may want to send the description change
as a separate patch, rebased on top of the cgroup/for-next branch.

I've rephrased the description to clarify that lockdep annotations
can occur even without CONFIG_PROVE_RCU. Feel free to use this
version or modify it further:
"Export locks for lockdep annotations. Use CONFIG_PROVE_RCU for
accessors in cgroup.h, and CONFIG_LOCKDEP for accessors that do not
require CONFIG_PROVE_RCU."

-- 
Cheers,
Kamalesh