linux-kernel - Re: [PATCH v5 6/6] x86/asm: Retire RIP_REL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f465a1b3-c28b-7bfe-7c18-e3fad41842aa@gmail.com>
Date: Fri, 18 Apr 2025 17:51:44 +0200
From: Uros Bizjak <ubizjak@...il.com>
To: Ard Biesheuvel <ardb+git@...gle.com>, linux-kernel@...r.kernel.org
Cc: linux-efi@...r.kernel.org, x86@...nel.org, mingo@...nel.org,
 Ard Biesheuvel <ardb@...nel.org>, Tom Lendacky <thomas.lendacky@....com>,
 Dionna Amalie Glaze <dionnaglaze@...gle.com>,
 Kevin Loughlin <kevinloughlin@...gle.com>
Subject: Re: [PATCH v5 6/6] x86/asm: Retire RIP_REL_REF()



On 18. 04. 25 16:13, Ard Biesheuvel wrote:
> From: Ard Biesheuvel <ardb@...nel.org>
> 
> Now that all users have been moved into startup/ where PIC codegen is
> used, RIP_REL_REF() is no longer needed. Remove it.
> 
> Signed-off-by: Ard Biesheuvel <ardb@...nel.org>
> ---
>   arch/x86/include/asm/asm.h | 5 -----
>   1 file changed, 5 deletions(-)
> 
> diff --git a/arch/x86/include/asm/asm.h b/arch/x86/include/asm/asm.h
> index a9f07799e337..eef0771512de 100644
> --- a/arch/x86/include/asm/asm.h
> +++ b/arch/x86/include/asm/asm.h
> @@ -120,11 +120,6 @@ static __always_inline __pure void *rip_rel_ptr(void *p)
>   
>   	return p;
>   }
> -#ifndef __pic__
> -#define RIP_REL_REF(var)	(*(typeof(&(var)))rip_rel_ptr(&(var)))
> -#else
> -#define RIP_REL_REF(var)	(var)
> -#endif
>   #endif

You can also remove rip_rel_ptr() with the whole "#ifndef __ASSEMBLER__" 
part.

Uros.