linux-kernel - Re: [PATCH v5 6/6] x86/asm: Retire RIP_REL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMj1kXH=nXgymC8XGO0cxRXJS=N2GY1fCvegSBG4_+mS2-cc4Q@mail.gmail.com>
Date: Fri, 18 Apr 2025 17:58:31 +0200
From: Ard Biesheuvel <ardb@...nel.org>
To: Uros Bizjak <ubizjak@...il.com>
Cc: Ard Biesheuvel <ardb+git@...gle.com>, linux-kernel@...r.kernel.org, 
	linux-efi@...r.kernel.org, x86@...nel.org, mingo@...nel.org, 
	Tom Lendacky <thomas.lendacky@....com>, Dionna Amalie Glaze <dionnaglaze@...gle.com>, 
	Kevin Loughlin <kevinloughlin@...gle.com>
Subject: Re: [PATCH v5 6/6] x86/asm: Retire RIP_REL_REF()

On Fri, 18 Apr 2025 at 17:51, Uros Bizjak <ubizjak@...il.com> wrote:
>
>
>
> On 18. 04. 25 16:13, Ard Biesheuvel wrote:
> > From: Ard Biesheuvel <ardb@...nel.org>
> >
> > Now that all users have been moved into startup/ where PIC codegen is
> > used, RIP_REL_REF() is no longer needed. Remove it.
> >
> > Signed-off-by: Ard Biesheuvel <ardb@...nel.org>
> > ---
> >   arch/x86/include/asm/asm.h | 5 -----
> >   1 file changed, 5 deletions(-)
> >
> > diff --git a/arch/x86/include/asm/asm.h b/arch/x86/include/asm/asm.h
> > index a9f07799e337..eef0771512de 100644
> > --- a/arch/x86/include/asm/asm.h
> > +++ b/arch/x86/include/asm/asm.h
> > @@ -120,11 +120,6 @@ static __always_inline __pure void *rip_rel_ptr(void *p)
> >
> >       return p;
> >   }
> > -#ifndef __pic__
> > -#define RIP_REL_REF(var)     (*(typeof(&(var)))rip_rel_ptr(&(var)))
> > -#else
> > -#define RIP_REL_REF(var)     (var)
> > -#endif
> >   #endif
>
> You can also remove rip_rel_ptr() with the whole "#ifndef __ASSEMBLER__"
> part.
>

No, rip_rel_ptr() needs to be kept, unfortunately.